Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update before render code async and pass markdown instance #322

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Update before render code async and pass markdown instance #322

merged 4 commits into from
Jun 19, 2024

Conversation

asimonok
Copy link
Collaborator

Resolves #316

@asimonok asimonok requested a review from mikhail-vl June 18, 2024 08:37
@asimonok asimonok self-assigned this Jun 18, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.15686% with 4 lines in your changes missing coverage. Please review.

Project coverage is 98.79%. Comparing base (165ecbf) to head (4c2c8c8).

Files Patch % Lines
src/utils/html.ts 66.66% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
+ Coverage   98.78%   98.79%   +0.01%     
==========================================
  Files          36       36              
  Lines         493      499       +6     
  Branches       70       72       +2     
==========================================
+ Hits          487      493       +6     
  Misses          6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added this to the Version 5.1.0 milestone Jun 19, 2024
@mikhail-vl mikhail-vl added the enhancement New feature or request label Jun 19, 2024
@mikhail-vl mikhail-vl changed the title Make before render code async and pass markdown instance Update before render code async and pass markdown instance Jun 19, 2024
mikhail-vl
mikhail-vl approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit dd47db2 into main Jun 19, 2024
5 of 7 checks passed
@mikhail-vl mikhail-vl deleted the feat/async-before-render-code branch June 19, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

Assignees

@asimonok asimonok

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 5.1.0
Development

Successfully merging this pull request may close these issues.

Task Lists
2 participants
@asimonok @mikhail-vl