Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update panel render if first data source does not have data #353

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Update panel render if first data source does not have data #353

merged 4 commits into from
Sep 5, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #352

@vitPinchuk vitPinchuk self-assigned this Sep 5, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.65%. Comparing base (583faa4) to head (f7ab8fd).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
+ Coverage   98.63%   98.65%   +0.01%     
==========================================
  Files          41       41              
  Lines         586      593       +7     
  Branches       92       93       +1     
==========================================
+ Hits          578      585       +7     
  Misses          8        8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitPinchuk vitPinchuk requested review from mikhail-vl and asimonok and removed request for mikhail-vl September 5, 2024 13:36
@mikhail-vl mikhail-vl added the enhancement New feature or request label Sep 5, 2024
@mikhail-vl mikhail-vl added this to the Text 5.4.0 milestone Sep 5, 2024
@mikhail-vl mikhail-vl changed the title Render panel if First Datasource Does Not Have Data Update panel render if first data source does not have data Sep 5, 2024
mikhail-vl
mikhail-vl approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit d2508a8 into main Sep 5, 2024
7 checks passed
@mikhail-vl mikhail-vl deleted the feat/BT-frame-issue-all-data branch September 5, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

@asimonok asimonok Awaiting requested review from asimonok

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
Business Suite
Archived in project
Milestone
Text 5.4.0
Development

Successfully merging this pull request may close these issues.

Panel Does Not Render When The First Datasource Does Not Have Data
2 participants
@vitPinchuk @mikhail-vl