Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add replace variables in URLs #376

Merged
merged 11 commits into from
Dec 9, 2024
Merged

Add replace variables in URLs #376

merged 11 commits into from
Dec 9, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #369

@vitPinchuk vitPinchuk self-assigned this Dec 3, 2024
@mikhail-vl mikhail-vl added the enhancement New feature or request label Dec 3, 2024
@mikhail-vl mikhail-vl added this to the Text 5.5.0 milestone Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (66ceec6) to head (5af8385).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #376   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files          41       41           
  Lines         602      603    +1     
  Branches       92       92           
=======================================
+ Hits          594      595    +1     
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitPinchuk Please resolve conflicts.

@vitPinchuk vitPinchuk requested a review from mikhail-vl December 9, 2024 14:27
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit 8037ca0 into main Dec 9, 2024
5 checks passed
@mikhail-vl mikhail-vl deleted the feat/replace-in-urls branch December 9, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Ability to include dashboard variables in CSS URLs
3 participants