Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table virtualization to improve performance #64

Merged
merged 14 commits into from
Oct 16, 2023

Conversation

asimonok
Copy link
Collaborator

@asimonok asimonok commented Sep 20, 2023

Resolves #63

@asimonok asimonok self-assigned this Sep 20, 2023
@mikhail-vl mikhail-vl added the enhancement New feature or request label Sep 25, 2023
@mikhail-vl mikhail-vl added this to the Version 1.8.0 milestone Sep 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (3ac92c3) 99.07% compared to head (0f5db40) 98.85%.

❗ Current head 0f5db40 differs from pull request most recent head 3123e97. Consider uploading reports for the commit 3123e97 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   99.07%   98.85%   -0.22%     
==========================================
  Files          50       50              
  Lines         753      785      +32     
  Branches      151      160       +9     
==========================================
+ Hits          746      776      +30     
+ Misses          2        1       -1     
- Partials        5        8       +3     
Files Coverage Δ
jest-setup.js 100.00% <100.00%> (ø)
src/components/ButtonView/ButtonView.tsx 100.00% <100.00%> (ø)
src/components/OptionsVariable/OptionsVariable.tsx 100.00% <100.00%> (ø)
src/components/TableView/TableView.tsx 100.00% <ø> (ø)
src/hooks/useRuntimeVariables.ts 100.00% <100.00%> (ø)
src/types/variable.ts 100.00% <ø> (ø)
src/utils/table.ts 97.72% <100.00%> (+0.13%) ⬆️
src/hooks/useTable.tsx 96.33% <93.75%> (-0.76%) ⬇️
src/utils/variable.ts 98.14% <95.23%> (+3.41%) ⬆️
src/components/Table/Table.tsx 95.23% <83.33%> (-4.77%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asimonok asimonok requested a review from mikhail-vl September 26, 2023 08:00
@asimonok asimonok marked this pull request as ready for review September 26, 2023 08:02
@mikhail-vl mikhail-vl changed the title Add table virtualization Add table virtualization to improve performance Oct 16, 2023
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit 306bfe7 into main Oct 16, 2023
4 checks passed
@mikhail-vl mikhail-vl deleted the feat/large-data-performance branch October 16, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large data set slows down in treeview
3 participants