Connection modification #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tants.SESSION_EVENT.CONNECTION_ERROR). Close connection when socket.destroyed
Added reconnect capability to the connections.
Modified connect() results with result as
{ connected: boolean, errors: [Error] }.
Added Authentication Error control.
Added Connection Erorr description.
Added Volttable Support.
Added adHoc and updateClasses sugar functions for Client.
Linted lib/* and test/*.
Modify test to adapt to new connections.
Modify test to use not localhost connection to voltdb.
Modify testrunner to run a specific test.
Added test to Volttable support.
Added test to Reconnect support.
Added tests to connections test. BadAuth. Reconnect. Mixed.
|
This pull request was made by changing the master branch. I will create a new one with all the changes in a different branch as it says in the CONTRIBUTING file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, I was having a problem with the callback keep getting called (#11 (comment)) that was ocurring because the Connection.flusher was keep getting because its interval was never cleared, and that produced an invocation of the callback because the callback was associated with the socket.on('error').
I changed that and some other things.