tools: remove no-goma arg from make-v8 script #438
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: Coverage Windows | |
| on: | |
| pull_request: | |
| types: [opened, synchronize, reopened, ready_for_review] | |
| paths: | |
| - lib/**/*.js | |
| - Makefile | |
| - src/**/*.cc | |
| - src/**/*.h | |
| - test/** | |
| - tools/gyp/** | |
| - tools/test.py | |
| - .github/workflows/coverage-windows.yml | |
| push: | |
| branches: | |
| - main | |
| paths: | |
| - lib/**/*.js | |
| - Makefile | |
| - src/**/*.cc | |
| - src/**/*.h | |
| - test/** | |
| - tools/gyp/** | |
| - tools/test.py | |
| - .github/workflows/coverage-windows.yml | |
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} | |
| cancel-in-progress: true | |
| env: | |
| PYTHON_VERSION: '3.12' | |
| FLAKY_TESTS: keep_retrying | |
| permissions: | |
| contents: read | |
| jobs: | |
| coverage-windows: | |
| if: github.event.pull_request.draft == false | |
| runs-on: windows-2022 | |
| steps: | |
| - uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6 | |
| with: | |
| persist-credentials: false | |
| - name: Set up Python ${{ env.PYTHON_VERSION }} | |
| uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0 | |
| with: | |
| python-version: ${{ env.PYTHON_VERSION }} | |
| - name: Install deps | |
| run: choco install nasm | |
| - name: Environment Information | |
| run: npx envinfo | |
| - name: Build | |
| run: ./vcbuild.bat | |
| # TODO(bcoe): investigate tests that fail with coverage enabled | |
| # on Windows. | |
| - name: Test | |
| run: ./vcbuild.bat test-ci-js; node -e 'process.exit(0)' | |
| env: | |
| NODE_V8_COVERAGE: ./coverage/tmp | |
| - name: Report | |
| run: npx c8 report | |
| env: | |
| NODE_OPTIONS: --max-old-space-size=8192 | |
| - name: Clean tmp | |
| run: npx rimraf ./coverage/tmp | |
| - name: Upload | |
| uses: codecov/codecov-action@125fc84a9a348dbcf27191600683ec096ec9021c # v4.4.1 | |
| with: | |
| directory: ./coverage | |
| token: ${{ secrets.CODECOV_TOKEN }} |