Skip to content

Commit

Permalink
fix(button): fix button typings (VIV-000) (#2001)
Browse files Browse the repository at this point in the history
Fix button typings

Co-authored-by: James Taylor <146064280+TaylorJ76@users.noreply.github.com>
  • Loading branch information
RichardHelm and TaylorJ76 authored Nov 14, 2024
1 parent b8c4a90 commit 2495865
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions libs/components/src/lib/fab/fab.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { attr } from '@microsoft/fast-element';
import { applyMixins } from '@microsoft/fast-foundation';
import { FoundationButton } from '../../shared/foundation/button';
import { VividFoundationButton } from '../../shared/foundation/button';
import type { Connotation, Size } from '../enums.js';
import { AffixIconWithTrailing } from '../../shared/patterns/affix';

Expand Down Expand Up @@ -29,7 +29,7 @@ export type FABSize = Extract<
* @component fab
* @slot icon - Slot to add an icon to fab.
*/
export class Fab extends FoundationButton {
export class Fab extends VividFoundationButton {
/**
* The connotation the fab should have.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { DOM } from '@microsoft/fast-element';
import { eventClick } from '@microsoft/fast-web-utilities';
import { fixture } from '../test-utilities/fixture';
import {
FoundationButton as Button,
VividFoundationButton as Button,
buttonTemplate as template,
} from './index';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import { html, ref } from '@microsoft/fast-element';
import type { ViewTemplate } from '@microsoft/fast-element';
import type { FoundationElementTemplate } from '@microsoft/fast-foundation';
import type { ButtonOptions, FoundationButton } from './button';
import type { ButtonOptions, VividFoundationButton } from './button';

/**
* The template for the {@link @microsoft/fast-foundation#(Button:class)} component.
* @public
*/
export const buttonTemplate: FoundationElementTemplate<
ViewTemplate<FoundationButton>,
ViewTemplate<VividFoundationButton>,
ButtonOptions
> = () => html`
<button
Expand Down
6 changes: 3 additions & 3 deletions libs/components/src/shared/foundation/button/button.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export type ButtonOptions = FoundationElementDefinition;
*
* @public
*/
export class FoundationButton extends FormAssociatedButton {
export class VividFoundationButton extends FormAssociatedButton {
/**
* Determines if the element should receive document focus on page load.
*
Expand Down Expand Up @@ -267,5 +267,5 @@ applyMixins(DelegatesARIAButton, ARIAGlobalStatesAndProperties);
* TODO: https://github.com/microsoft/fast/issues/3317
* @internal
*/
export interface FoundationButton extends DelegatesARIAButton {}
applyMixins(FoundationButton, DelegatesARIAButton);
export interface VividFoundationButton extends DelegatesARIAButton {}
applyMixins(VividFoundationButton, DelegatesARIAButton);

0 comments on commit 2495865

Please sign in to comment.