Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(code): adopt tsdoc #110

Merged
merged 10 commits into from
Dec 21, 2022
Merged

style(code): adopt tsdoc #110

merged 10 commits into from
Dec 21, 2022

Conversation

yinonov
Copy link
Contributor

@yinonov yinonov commented Jan 6, 2022

replaces JSDoc with TSDoc

@yinonov yinonov changed the title style(code): adopt tsdocs style(code): adopt tsdoc Jan 6, 2022
@yinonov
Copy link
Contributor Author

yinonov commented Jan 6, 2022

Might need to avoid TSDoc at this point due to lack of enforcement support

microsoft/tsdoc#209

@yinonov yinonov added Type: Style ⭐ changes that do not affect the meaning of the code Question Further information is requested labels Jan 6, 2022
YonatanKra
YonatanKra previously approved these changes Jan 9, 2022
@YonatanKra
Copy link
Contributor

Short remark - need to add documentation on how we are going to use that.

@yinonov yinonov marked this pull request as draft January 9, 2022 12:07
@yinonov yinonov closed this Jun 19, 2022
@yinonov yinonov reopened this Dec 16, 2022
@rinaok rinaok marked this pull request as ready for review December 21, 2022 09:25
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Merging #110 (bf1ea22) into main (d61b119) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              main      #110    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          123       194    +71     
  Lines         1562      2157   +595     
  Branches       108       133    +25     
==========================================
+ Hits          1562      2157   +595     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/components/src/lib/badge/badge.ts 100.00% <ø> (ø)
libs/components/src/lib/button/button.template.ts 100.00% <ø> (ø)
libs/components/src/lib/fab/fab.template.ts 100.00% <ø> (ø)
libs/components/src/lib/header/header.template.ts 100.00% <ø> (ø)
libs/components/src/lib/layout/layout.ts 100.00% <ø> (ø)
.../src/lib/accordion-item/accordion-item.template.ts 100.00% <100.00%> (ø)
...bs/components/src/lib/accordion-item/definition.ts 100.00% <100.00%> (ø)
libs/components/src/lib/accordion-item/index.ts 100.00% <100.00%> (ø)
libs/components/src/lib/accordion/definition.ts 100.00% <100.00%> (ø)
libs/components/src/lib/accordion/index.ts 100.00% <100.00%> (ø)
... and 148 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@YonatanKra YonatanKra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rinaok rinaok merged commit adea454 into main Dec 21, 2022
@rinaok rinaok deleted the tsdocs branch December 21, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Question Further information is requested Type: Style ⭐ changes that do not affect the meaning of the code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants