feat(tag): migrate tag component (VIV-944) #1100
Conversation
…migrate-tag-component
Codecov Report
@@ Coverage Diff @@
## main #1100 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 123 234 +111
Lines 1562 2571 +1009
Branches 108 139 +31
===========================================
+ Hits 1562 2571 +1009
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 128 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rinaok
added
Focus: Vivid Parity
|
|
||
| Set the `appearance` attribute to change the tag's appearance. | ||
|
|
||
| - Type: `'subtle'` | `'duotone'` |
There was a problem hiding this comment.
why subtle instead of filled as used for buttons or avatars? (especially considering that duotone tags look more subtle than the filled ones ;)
There was a problem hiding this comment.
There was a problem hiding this comment.
@olaf-k filled is different in its color shades.
| ```html preview | ||
| <vwc-tag label="disabled" disabled></vwc-tag> | ||
| ``` | ||
|
|
There was a problem hiding this comment.
what is the reason why it couldn't be both? (looks like removable "wins" at this point.)
libs/components/src/lib/tag/tag.ts
Outdated
| #select = (): void => { | ||
| if (!this.selectable || this.disabled || this.removable) { | ||
| return; | ||
| } | ||
| this.selected = !this.selected; | ||
| this.$emit('selected-change'); | ||
| }; |
There was a problem hiding this comment.
I like this solution even better than writing tests for it!
Co-authored-by: Yonatan Kra <yonatan.kra@vonage.com>
|
|
||
| Set the `appearance` attribute to change the tag's appearance. | ||
|
|
||
| - Type: `'subtle'` | `'duotone'` |
There was a problem hiding this comment.
@olaf-k filled is different in its color shades.
|
@AyalaBu Found the original design from vivid-2 |
Co-authored-by: rachelbt <rachelbt@users.noreply.github.com>
No description provided.