Skip to content

Commit

Permalink
feat(pagination): iss 747 viv 392 pagination (#759)
Browse files Browse the repository at this point in the history
* issue #747: initial commit

* issue #747: pagination beginning

* issue #747: initial implementatioin

* issue #747: wip

* issue #747: wip

* issue #747: wip

* issue #747: added event and tested

* issue #747: merged with master

* issue #747: fixed layout

* issue #747: added tests for layout

* issue #747 fixing dep check

* issue #747: implementation changes

* issue #747: fixing the tests

* issue #747: testing uncovered parts

* fixed the render

* issue #747: added slotted prev/next example

* issue #747: added ripple

* issue #747: moving the pagination to the beta area

* issue #747: added test coverage to the new areas of pagination

* issue #747: fixing the storybook mark

Co-authored-by: yinon <yinon@hotmail.com>
  • Loading branch information
gullerya and yinonov authored Apr 18, 2021
1 parent 75553d6 commit 9b35300
Show file tree
Hide file tree
Showing 21 changed files with 2,741 additions and 76 deletions.
4 changes: 4 additions & 0 deletions __snapshots__/data grid renderers customization.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-17">
</vaadin-grid-cell-content>
</vaadin-grid>

```

#### `should render footer text by default`
Expand Down Expand Up @@ -142,6 +143,7 @@
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-17">
</vaadin-grid-cell-content>
</vaadin-grid>

```

#### `should render custom header when renderer provided`
Expand Down Expand Up @@ -212,6 +214,7 @@
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-17">
</vaadin-grid-cell-content>
</vaadin-grid>

```

#### `should render custom footer when renderer provided`
Expand Down Expand Up @@ -285,6 +288,7 @@
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-17">
</vaadin-grid-cell-content>
</vaadin-grid>

```

#### `should render custom cell when renderer provided`
Expand Down
32 changes: 17 additions & 15 deletions __snapshots__/data grid selection UI.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-17">
</vaadin-grid-cell-content>
</vaadin-grid>

```

#### `should not render selector header when single mode`
Expand Down Expand Up @@ -167,6 +168,7 @@
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-17">
</vaadin-grid-cell-content>
</vaadin-grid>

```

#### `should not render selector header when dataProvider used (even if multi mode)`
Expand Down Expand Up @@ -249,9 +251,10 @@
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-17">
</vaadin-grid-cell-content>
</vaadin-grid>

```

#### `should show header when switching from single to multi (items data provider)`
#### `should hide header when switching from multi to single (items data provider)`

```html
<vaadin-grid
Expand Down Expand Up @@ -307,11 +310,6 @@
true
</vaadin-grid-cell-content>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-0">
<vwc-checkbox
aria-label="Select All"
class="vvd-all-selector"
>
</vwc-checkbox>
</vaadin-grid-cell-content>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-10">
<vwc-data-grid-header path="y">
Expand All @@ -336,9 +334,10 @@
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-17">
</vaadin-grid-cell-content>
</vaadin-grid>

```

#### `should show header when switching from single to multi, indeterminate when some selected (items data provider)`
#### `should show header when switching from single to multi (items data provider)`

```html
<vaadin-grid
Expand All @@ -357,7 +356,6 @@
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-1">
<vwc-checkbox
aria-label="Select Row"
checked=""
class="vvd-row-selector"
>
</vwc-checkbox>
Expand Down Expand Up @@ -397,7 +395,6 @@
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-0">
<vwc-checkbox
aria-label="Select All"
checked=""
class="vvd-all-selector"
>
</vwc-checkbox>
Expand Down Expand Up @@ -425,10 +422,9 @@
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-17">
</vaadin-grid-cell-content>
</vaadin-grid>

```

#### `should show header when switching from single to multi, selected when all selected (items data provider)`
#### `should show header when switching from single to multi, indeterminate when some selected (items data provider)`

```html
<vaadin-grid
Expand Down Expand Up @@ -461,7 +457,6 @@
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-4">
<vwc-checkbox
aria-label="Select Row"
checked=""
class="vvd-row-selector"
>
</vwc-checkbox>
Expand All @@ -475,7 +470,6 @@
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-7">
<vwc-checkbox
aria-label="Select Row"
checked=""
class="vvd-row-selector"
>
</vwc-checkbox>
Expand Down Expand Up @@ -517,10 +511,9 @@
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-17">
</vaadin-grid-cell-content>
</vaadin-grid>

```

#### `should hide header when switching from multi to single (items data provider)`
#### `should show header when switching from single to multi, selected when all selected (items data provider)`

```html
<vaadin-grid
Expand All @@ -539,6 +532,7 @@
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-1">
<vwc-checkbox
aria-label="Select Row"
checked=""
class="vvd-row-selector"
>
</vwc-checkbox>
Expand All @@ -552,6 +546,7 @@
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-4">
<vwc-checkbox
aria-label="Select Row"
checked=""
class="vvd-row-selector"
>
</vwc-checkbox>
Expand All @@ -565,6 +560,7 @@
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-7">
<vwc-checkbox
aria-label="Select Row"
checked=""
class="vvd-row-selector"
>
</vwc-checkbox>
Expand All @@ -576,6 +572,12 @@
true
</vaadin-grid-cell-content>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-0">
<vwc-checkbox
aria-label="Select All"
checked=""
class="vvd-all-selector"
>
</vwc-checkbox>
</vaadin-grid-cell-content>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-10">
<vwc-data-grid-header path="y">
Expand Down
64 changes: 31 additions & 33 deletions __snapshots__/data grid.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

```

#### `should reflect columns redefinition on refreshConfiguration (header, hidden, frozen)`
#### `should reflect columns redefinition on refreshConfiguration (sortable, resizable)`

```html
<vaadin-grid
Expand All @@ -31,7 +31,10 @@
</vwc-data-grid-header>
</vaadin-grid-cell-content>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-1">
<vwc-data-grid-header path="y">
<vwc-data-grid-header
path="y"
sortable=""
>
B
</vwc-data-grid-header>
</vaadin-grid-cell-content>
Expand Down Expand Up @@ -73,7 +76,10 @@
</vwc-data-grid-header>
</vaadin-grid-cell-content>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-1">
<vwc-data-grid-header path="y">
<vwc-data-grid-header
path="y"
sortable=""
>
B
</vwc-data-grid-header>
</vaadin-grid-cell-content>
Expand Down Expand Up @@ -103,32 +109,38 @@
style="touch-action: none;"
theme="no-border"
>
<vaadin-grid-column
hidden=""
path="x"
>
<vaadin-grid-column path="x">
</vaadin-grid-column>
<vaadin-grid-column path="y">
</vaadin-grid-column>
<vaadin-grid-column
frozen=""
path="z"
resizable=""
>
</vaadin-grid-column>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-0">
<vwc-data-grid-header path="x">
A
</vwc-data-grid-header>
</vaadin-grid-cell-content>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-1">
<vwc-data-grid-header path="y">
B1
B
</vwc-data-grid-header>
</vaadin-grid-cell-content>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-2">
<vwc-data-grid-header path="z">
C
</vwc-data-grid-header>
</vaadin-grid-cell-content>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-3">
</vaadin-grid-cell-content>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-4">
</vaadin-grid-cell-content>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-5">
</vaadin-grid-cell-content>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-6">
</vaadin-grid-cell-content>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-7">
</vaadin-grid-cell-content>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-8">
Expand All @@ -137,7 +149,7 @@

```

#### `should reflect columns redefinition on refreshConfiguration (sortable, resizable)`
#### `should reflect columns redefinition on refreshConfiguration (header, hidden, frozen)`

```html
<vaadin-grid
Expand All @@ -156,10 +168,7 @@
</vwc-data-grid-header>
</vaadin-grid-cell-content>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-1">
<vwc-data-grid-header
path="y"
sortable=""
>
<vwc-data-grid-header path="y">
B
</vwc-data-grid-header>
</vaadin-grid-cell-content>
Expand All @@ -181,7 +190,6 @@
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-8">
</vaadin-grid-cell-content>
</vaadin-grid>

```

```html
Expand All @@ -201,10 +209,7 @@
</vwc-data-grid-header>
</vaadin-grid-cell-content>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-1">
<vwc-data-grid-header
path="y"
sortable=""
>
<vwc-data-grid-header path="y">
B
</vwc-data-grid-header>
</vaadin-grid-cell-content>
Expand All @@ -226,50 +231,43 @@
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-8">
</vaadin-grid-cell-content>
</vaadin-grid>

```

```html
<vaadin-grid
style="touch-action: none;"
theme="no-border"
>
<vaadin-grid-column path="x">
<vaadin-grid-column
hidden=""
path="x"
>
</vaadin-grid-column>
<vaadin-grid-column path="y">
</vaadin-grid-column>
<vaadin-grid-column
frozen=""
path="z"
resizable=""
>
</vaadin-grid-column>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-0">
<vwc-data-grid-header path="x">
A
</vwc-data-grid-header>
</vaadin-grid-cell-content>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-1">
<vwc-data-grid-header path="y">
B
B1
</vwc-data-grid-header>
</vaadin-grid-cell-content>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-2">
<vwc-data-grid-header path="z">
C
</vwc-data-grid-header>
</vaadin-grid-cell-content>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-3">
</vaadin-grid-cell-content>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-4">
</vaadin-grid-cell-content>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-5">
</vaadin-grid-cell-content>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-6">
</vaadin-grid-cell-content>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-7">
</vaadin-grid-cell-content>
<vaadin-grid-cell-content slot="vaadin-grid-cell-content-8">
</vaadin-grid-cell-content>
</vaadin-grid>

```

1 change: 1 addition & 0 deletions __snapshots__/file picker.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
</slot>
</div>
</label>

```

#### `should have the expected internal contents (with label)`
Expand Down
1 change: 1 addition & 0 deletions __snapshots__/helper message.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,4 @@
</span>

```

Loading

0 comments on commit 9b35300

Please sign in to comment.