Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vwc-tags): 1st component draft #1016

Merged
merged 226 commits into from
Oct 3, 2021
Merged

feat(vwc-tags): 1st component draft #1016

merged 226 commits into from
Oct 3, 2021

Conversation

tveinfeld
Copy link
Contributor

This is the first draft for a Chip component. See https://jira.vonage.com/browse/VIV-652 for more information.

image

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: a2372bd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

@rinaok rinaok requested a review from yinonov October 3, 2021 15:19
@rinaok rinaok marked this pull request as ready for review October 3, 2021 15:20
rinaok
rinaok previously approved these changes Oct 3, 2021
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yinonov yinonov merged commit 8cb87e2 into master Oct 3, 2021
@yinonov yinonov deleted the viv-652-chips branch October 3, 2021 16:59
@rinaok rinaok mentioned this pull request Apr 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yinonov yinonov yinonov left review comments

@rinaok rinaok rinaok left review comments

Assignees
No one assigned
Labels
Work in Progress You're welcome to have a look around and drop your early comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tveinfeld @yinonov @rinaok