Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viv-243: duplication of styles when scheme misconfigured #419

Closed
gullerya opened this issue Nov 2, 2020 · 0 comments · Fixed by #420
Closed

viv-243: duplication of styles when scheme misconfigured #419

gullerya opened this issue Nov 2, 2020 · 0 comments · Fixed by #420
Assignees
Labels
Type: Bug 🐞 Something isn't working

Comments

@gullerya
Copy link
Contributor

gullerya commented Nov 2, 2020

Describe the bug
It might wrongly happen that scheme service is initialised more than once - in this case the scheme will install multiple styles which is bad and can be prevented.

To Reproduce
import vvd-scheme once with some specific query
import vvd-scheme second time with other query
observe the style elements and see that there are 2 styles installed

Expected behavior
in a case of duplicate init only 1 style should be installed
in a case of duplicate init error should be logged to the console

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@gullerya gullerya added the Type: Bug 🐞 Something isn't working label Nov 2, 2020
@gullerya gullerya self-assigned this Nov 2, 2020
gullerya added a commit that referenced this issue Nov 4, 2020
gullerya added a commit that referenced this issue Nov 4, 2020
* issue #419: fixing scheme duplicate styles load

* issue #419: added tests to cover the multi init stuff

* fixing general lint isues

* apparently lint fix broken the TS, so some adjustment

* issue #419: fixing unnecessary logging issue

* issue #419: fixing CR reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant