Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue #419 / VIV-243 - fixing scheme duplicate styles load #420

Merged
merged 8 commits into from
Nov 4, 2020
Merged

fix: issue #419 / VIV-243 - fixing scheme duplicate styles load #420

merged 8 commits into from
Nov 4, 2020

Conversation

gullerya
Copy link
Contributor

@gullerya gullerya commented Nov 2, 2020

closes #419

@gullerya gullerya requested a review from yinonov November 2, 2020 16:57
@github-actions
Copy link

github-actions bot commented Nov 2, 2020

PR showcase deployed here.

@gullerya gullerya changed the title issue #419: fixing scheme duplicate styles load fix: issue #419 / VIV-243 - fixing scheme duplicate styles load Nov 2, 2020
@gullerya gullerya added the Type: Bug 🐞 Something isn't working label Nov 3, 2020
YonatanKra
YonatanKra approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@YonatanKra YonatanKra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - squash it!

@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gullerya gullerya merged commit 564724f into master Nov 4, 2020
@gullerya gullerya deleted the iss-419/viv-243-scheme-duplication branch November 4, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YonatanKra YonatanKra YonatanKra approved these changes

@yinonov yinonov Awaiting requested review from yinonov

Assignees
No one assigned
Labels
Type: Bug 🐞 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

viv-243: duplication of styles when scheme misconfigured
2 participants
@gullerya @YonatanKra