-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(breadcrumb): add the breadcrumb component #1260
Conversation
🚀 Latest successful build of the PR deployed here. 🚀 |
}, | ||
"dependencies": { | ||
"@vonage/vvd-foundation": "^2.26.0", | ||
"lit-element": "^2.4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vvd-core
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it should be imported in all vivid < 3
components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually - it doesn't use any of these...
I've removed v-2 deps. Left only umbrella for build time dep.
Co-authored-by: yinon <yinon@hotmail.com>
# Conflicts: # components/icon/package.json # components/icon/src/vwc-icon.ts
const style = document.createElement('style'); | ||
style.innerHTML = ` | ||
vwc-breadcrumb { | ||
--icon-size: 14px; | ||
} | ||
`; | ||
document.head.appendChild(style); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to set the icon
's size inside the element.
Since we have no access to the scss
file and actually have no scss
file, this is the way I thought of doing it.
Got a suggestion?
Co-authored-by: yinon <yinon@hotmail.com>
b0898d1
to
71381db
Compare
513ce48
to
cb6df73
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
}, | ||
"scripts": { | ||
"build:typescript": "tsc -b", | ||
"build:styles": "umbrella-style-modules --cssLib '@microsoft/fast-element'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok got it
</vwc-breadcrumb>`; | ||
|
||
export const Basic = Template.bind({}); | ||
Basic.args = { label: 'Basic', disabled: 'false' }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's no use of either of them in the code - I think you better remove them, less confusion to our users :)
Adds the
breadcrumb
andbreadcrumb-item
components.Note that this is "quick and dirty" as
vivid-2
is deprecated. No unit tests involved - mainly copy-paste of code fromvivid-3