Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(card): omit elevation in favor of card #1278

Merged
merged 7 commits into from
Jun 19, 2022
Merged

feat(card): omit elevation in favor of card #1278

merged 7 commits into from
Jun 19, 2022

Conversation

yinonov
Copy link
Contributor

@yinonov yinonov commented Apr 10, 2022

omit elevation in favor of card elevation member support

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@yinonov
feat(card): omit elevation in favor of card
2311575 
omit elevation in favor of card elevation member support
@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

yinonov
yinonov commented Apr 15, 2022
View reviewed changes
Copy link
Contributor Author

@yinonov yinonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add a card story covering elevation

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rachelbt
Copy link
Contributor

rachelbt commented May 4, 2022 •
edited
Loading

@yinonov
I'm not so sure about leaving the elevation out.
When using card just for out line there are two things:

  • the content slot is nested inside a div with padding of 24px; This is not always needed. One can use one of the other slots but that's not what they are for.
  • when using card - we still have un-needed HTML that is generated with the card but has display:none, or empty slots (header + footer.

I find elevation more clean to use.

@rachelbt rachelbt marked this pull request as ready for review June 15, 2022 10:33
@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

yinonov
yinonov commented Jun 19, 2022
View reviewed changes
Copy link
Contributor Author

@yinonov yinonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rachelbt rachelbt merged commit 9f1c4c6 into master Jun 19, 2022
@yinonov yinonov deleted the omit-elevation-in-favor-of-card branch June 19, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachelbt rachelbt rachelbt approved these changes

Assignees

@rachelbt rachelbt

Labels
None yet
Projects
Vivid Roadmap
Status: Done ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yinonov @rachelbt