Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(dev-environment): modify environment config for output stability #507

Merged
merged 8 commits into from
Dec 27, 2020

Conversation

yinonov
Copy link
Contributor

@yinonov yinonov commented Dec 13, 2020

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@yinonov yinonov marked this pull request as draft December 13, 2020 17:15
@yinonov yinonov marked this pull request as ready for review December 18, 2020 08:56
tsconfig.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@gullerya
Copy link
Contributor

gullerya commented Dec 20, 2020

I've read a bit about that Volta thing and honestly think that it's not useful for us.
This may be in use in the final project, like VonageAI or Nexmo, but we, as a library, can't expect any environment pinning or do it ourselves.
And if not used in conjunction with Volta - that addition in the package.json is useless, so I'd remove this part.

@github-actions
Copy link

github-actions bot commented Dec 20, 2020

File Coverage
All files 79%
common/context/src/vvd-context.ts 97%
common/fonts/src/vvd-fonts.ts 83%
common/foundation/src/form-association/associate-with-form.ts 89%
common/foundation/src/form-association/common.ts 90%
common/foundation/src/form-association/submit-on-enter-key.ts 80%
common/scheme/src/os-sync.utils.ts 58%
common/scheme/src/vvd-scheme-style-tag-handler.ts 79%
common/scheme/src/vvd-scheme.ts 82%
components/audio/src/vwc-audio.ts 60%
components/button/src/vwc-button.ts 78%
components/carousel/src/vwc-carousel.ts 71%
components/drawer/src/vwc-drawer.ts 42%
components/fab/src/vwc-fab.ts 63%
components/file-picker/src/vwc-file-picker.ts 67%
components/icon-button-toggle/src/vwc-icon-button-toggle.ts 67%
components/icon-button/src/vwc-icon-button.ts 67%
components/icon/src/vwc-icon.js 92%
components/list/src/vwc-list-item.ts 80%
components/media-controller/src/vwc-media-controller.ts 84%
components/select/src/vwc-select.ts 90%
components/slider/src/vwc-slider.ts 88%
components/textarea/src/vwc-textarea.ts 81%
components/textfield/src/vwc-textfield.ts 90%
components/theme-switch/src/vwc-theme-switch.ts 88%

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against 2eb2bda

@gullerya gullerya self-requested a review December 27, 2020 19:20
@sonarcloud
Copy link

sonarcloud bot commented Dec 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gullerya gullerya merged commit 737d246 into master Dec 27, 2020
@gullerya gullerya deleted the environment-strictness branch December 27, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants