Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vwc-helper-message): iss 578 a11y for helper #586

Merged
merged 7 commits into from
Jan 19, 2021

Conversation

gullerya
Copy link
Contributor

closes #578
Things that verified and done here:

  • added aria label to the icon image, to point to the error message
  • changed the class to an ID to achieve the above one and to be future proof

In general - there is an issue with A11Y crossing the boundaries of the Shadow DOM. The spec is in discussion and not finalized. As of now - cross boundaries A11Y parts are not available.

@gullerya gullerya requested a review from yinonov January 18, 2021 11:28
@github-actions
Copy link

🚀

Latest successful build of the PR deployed here.

🚀

@gullerya gullerya added the enhancement New feature or request label Jan 18, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gullerya gullerya merged commit 5b49f3c into master Jan 19, 2021
@gullerya gullerya deleted the iss-578-a11y-for-helper branch January 19, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(vwc-helper-message): check for appropriate a11i / aria labeling
2 participants