fix(vwc-carousel): white source report high severity for carousel #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Latest successful build of the PR deployed here. 🚀 |
yinonov
changed the title
..not by the hair of my chinny, chin, chin! |
…age/vivid into VIV-493-swiper-high-severity
|
Kudos, SonarCloud Quality Gate passed!
|
tveinfeld
approved these changes
Apr 18, 2021
yinonov
commented
Apr 18, 2021
| aria-disabled="true" | ||
| aria-label="Previous slide" | ||
| class="swiper-button-disabled swiper-button-prev swiper-nav" | ||
| role="button" |
There was a problem hiding this comment.
This shouldn't have been dropped. My bad? I don't recall seeing it in template. Dynamically set in run-time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swiper major version update breaks scss paths.
as documented in swiper a minimized scss bundle is available
@forward 'swiper/swiper-bundle.min.css';@gullerya if previous imports deliberately referenced individual components raise a flag
removing
@types/swiperas of version 6 swiper is fully typed