fix(vwc-slider): issue #789 fixing the slider miscalc when rendered in display none or resized #791
Conversation
|
🚀 Latest successful build of the PR deployed here. 🚀 |
| @@ -37,3 +37,16 @@ export function assert(condition: unknown, msg?: string): asserts condition { | |||
| throw new Error(msg); | |||
| } | |||
| } | |||
|
|
|||
| /* eslint-disable @typescript-eslint/no-explicit-any */ | |||
| export function debounce( | |||
There was a problem hiding this comment.
Good fit as decorator instead of argumenting the context
There was a problem hiding this comment.
I'll try that out - can decorator be put on the function instead of class and still preserve this?
I'd not like to put decorator on class level with a list of methods to be decorated, but rather decorate a single method...
components/slider/src/vwc-slider.ts
Outdated
| @@ -33,4 +47,9 @@ export class VWCSlider extends MWCSlider { | |||
| super.focus(); | |||
| this.formElement.focus(); | |||
| } | |||
|
|
|||
| @debounced(96) | |||
|
|
||
| wrapper.style.display = 'block'; | ||
| assertComputedStyle(slider, { width: '120px' }); | ||
| await waitInterval(160); |
There was a problem hiding this comment.
Can we use updateComplete because layout was called?
Maybe on every resize, set updateComplete to pending and call the debounced layout?
|
Kudos, SonarCloud Quality Gate passed!
|
gullerya
dismissed
yinonov’s stale review
The changes requested were implemented.
closes #789
The issue self is on the MWC side, and there is an issue opened on the same malfunction here.
I've provided here a local solution based on ResizeObserver, until MWC team will resolve it on their side.