Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Conversation Event / Voice recording validation #563

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Conversation

SMadani
Copy link
Contributor

@SMadani SMadani commented Feb 4, 2025

Removes from validation in Event creation and reintroduces URL domain host validation in Voice API downloadRecordingRaw method.

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.19%. Comparing base (4e22067) to head (9743af8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #563   +/-   ##
=========================================
  Coverage     98.19%   98.19%           
- Complexity     3937     3939    +2     
=========================================
  Files           564      564           
  Lines          8735     8738    +3     
  Branches        498      499    +1     
=========================================
+ Hits           8577     8580    +3     
  Misses          136      136           
  Partials         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SMadani SMadani merged commit fa39042 into main Feb 4, 2025
17 checks passed
@SMadani SMadani deleted the validation branch February 4, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants