Skip to content

Commit

Permalink
Merge 1c78e1d into 31d62cb
Browse files Browse the repository at this point in the history
  • Loading branch information
superchilled authored Sep 14, 2023
2 parents 31d62cb + 1c78e1d commit 9372157
Show file tree
Hide file tree
Showing 15 changed files with 31 additions and 27 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
with:
ruby-version: ${{ matrix.ruby }}
- name: Install dependencies
run: bundle install --without development
run: bundle install
- name: Run tests
run: bundle exec rake test
env:
Expand Down
4 changes: 4 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 7.15.1

* Updates Meetings endpoints to `v1`. [#286](https://github.com/Vonage/vonage-ruby-sdk/pull/286)

# 7.15.0

* Adds Users. [#282](https://github.com/Vonage/vonage-ruby-sdk/pull/282)
Expand Down
2 changes: 1 addition & 1 deletion lib/vonage/meetings/applications.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class Meetings::Applications < Namespace
#
# @see https://developer.vonage.com/en/api/meetings#updateApplication
def update(default_theme_id:)
request("/meetings/applications", params: {update_details: {default_theme_id: default_theme_id}}, type: Patch)
request("/v1/meetings/applications", params: {update_details: {default_theme_id: default_theme_id}}, type: Patch)
end
end
end
2 changes: 1 addition & 1 deletion lib/vonage/meetings/dial_in_numbers.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class Meetings::DialInNumbers < Namespace
#
# @see https://developer.vonage.com/en/api/meetings#getDialInNumbers
def list
request("/meetings/dial-in-numbers", response_class: ListResponse)
request("/v1/meetings/dial-in-numbers", response_class: ListResponse)
end
end
end
4 changes: 2 additions & 2 deletions lib/vonage/meetings/recordings.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class Meetings::Recordings < Namespace
#
# @see https://developer.vonage.com/en/api/meetings#getRecording
def info(recording_id:)
request("/meetings/recordings/" + recording_id)
request("/v1/meetings/recordings/" + recording_id)
end

# Delete a specified recording.
Expand All @@ -30,7 +30,7 @@ def info(recording_id:)
#
# @see https://developer.vonage.com/en/api/meetings#deleteRecording
def delete(recording_id:)
request("/meetings/recordings/" + recording_id, type: Delete)
request("/v1/meetings/recordings/" + recording_id, type: Delete)
end
end
end
8 changes: 4 additions & 4 deletions lib/vonage/meetings/rooms.rb
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class Meetings::Rooms < Namespace
#
# @see https://developer.vonage.com/en/api/meetings#getRooms
def list(**params)
path = "/meetings/rooms"
path = "/v1/meetings/rooms"
path += "?#{Params.encode(params)}" unless params.empty?

request(path, response_class: ListResponse)
Expand All @@ -38,7 +38,7 @@ def list(**params)
#
# @see https://developer.vonage.com/en/api/meetings#getRoom
def info(room_id:)
request("/meetings/rooms/" + room_id)
request("/v1/meetings/rooms/" + room_id)
end

# Create a new room.
Expand Down Expand Up @@ -96,7 +96,7 @@ def info(room_id:)
# @see https://developer.vonage.com/en/api/meetings#createRoom
def create(display_name:, **params)
request(
"/meetings/rooms",
"/v1/meetings/rooms",
params: params.merge({ display_name: display_name }),
type: Post
)
Expand Down Expand Up @@ -144,7 +144,7 @@ def create(display_name:, **params)
def update(room_id:, **params)
raise ArgumentError, 'must provide at least one other param in addition to :room_id' if params.empty?
request(
"/meetings/rooms/" + room_id,
"/v1/meetings/rooms/" + room_id,
params: {
update_details: params
},
Expand Down
2 changes: 1 addition & 1 deletion lib/vonage/meetings/sessions.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class Meetings::Sessions < Namespace
# @see https://developer.vonage.com/en/api/meetings#getSessionRecordings
def list_recordings(session_id:)
request(
"/meetings/sessions/" + session_id + "/recordings",
"/v1/meetings/sessions/" + session_id + "/recordings",
response_class: ListResponse
)
end
Expand Down
16 changes: 8 additions & 8 deletions lib/vonage/meetings/themes.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class Meetings::Themes < Namespace
#
# @see https://developer.vonage.com/en/api/meetings#getThemes
def list
request("/meetings/themes", response_class: ListResponse)
request("/v1/meetings/themes", response_class: ListResponse)
end

# Return information for specified theme.
Expand All @@ -28,7 +28,7 @@ def list
#
# @see https://developer.vonage.com/en/api/meetings#getThemeById
def info(theme_id:)
request("/meetings/themes/" + theme_id)
request("/v1/meetings/themes/" + theme_id)
end

# Create a new theme.
Expand All @@ -50,7 +50,7 @@ def info(theme_id:)
# @see https://developer.vonage.com/en/api/meetings#createTheme
def create(main_color:, brand_text:, **params)
request(
"/meetings/themes",
"/v1/meetings/themes",
params: params.merge(main_color: main_color, brand_text: brand_text),
type: Post
)
Expand All @@ -77,7 +77,7 @@ def create(main_color:, brand_text:, **params)
# @see https://developer.vonage.com/en/api/meetings#updateTheme
def update(theme_id:, **params)
request(
"/meetings/themes/" + theme_id,
"/v1/meetings/themes/" + theme_id,
params: {
update_details: params
},
Expand All @@ -97,7 +97,7 @@ def update(theme_id:, **params)
# @see https://developer.vonage.com/en/api/meetings#deleteTheme
def delete(theme_id:, force: false)
request(
"/meetings/themes/" + theme_id + "?force=#{force}",
"/v1/meetings/themes/" + theme_id + "?force=#{force}",
type: Delete
)
end
Expand All @@ -116,7 +116,7 @@ def delete(theme_id:, force: false)
#
# @see https://developer.vonage.com/en/api/meetings#getRoomsByThemeId
def list_rooms(theme_id:, **params)
path = "/meetings/themes/" + theme_id + "/rooms"
path = "/v1/meetings/themes/" + theme_id + "/rooms"
path += "?#{Params.encode(params)}" unless params.empty?

request(path, response_class: Meetings::Rooms::ListResponse)
Expand Down Expand Up @@ -164,7 +164,7 @@ def set_logo(theme_id:, filepath:, logo_type:)
private

def get_logo_upload_credentials
request("/meetings/themes/logos-upload-urls", response_class: ListResponse)
request("/v1/meetings/themes/logos-upload-urls", response_class: ListResponse)
end

def upload_logo_file(filepath:, credentials:)
Expand All @@ -185,7 +185,7 @@ def upload_logo_file(filepath:, credentials:)

def finalize_logos(theme_id:, keys: [])
request(
"/meetings/themes/" + theme_id + "/finalizeLogos",
"/v1/meetings/themes/" + theme_id + "/finalizeLogos",
params: {
keys: keys
},
Expand Down
2 changes: 1 addition & 1 deletion lib/vonage/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# typed: strong

module Vonage
VERSION = "7.15.0"
VERSION = "7.15.1"
end
2 changes: 1 addition & 1 deletion test/vonage/meetings/applications_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ def applications
end

def applications_uri
"https://" + meetings_host + "/meetings/applications"
"https://" + meetings_host + "/v1/meetings/applications"
end

def test_update_method
Expand Down
2 changes: 1 addition & 1 deletion test/vonage/meetings/dial_in_numbers_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ def dial_in_numbers
end

def dial_in_numbers_uri
"https://" + meetings_host + "/meetings/dial-in-numbers"
"https://" + meetings_host + "/v1/meetings/dial-in-numbers"
end

def list_response
Expand Down
2 changes: 1 addition & 1 deletion test/vonage/meetings/recordings_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ def recordings
end

def recording_uri
"https://" + meetings_host + "/meetings/recordings/" + meetings_id
"https://" + meetings_host + "/v1/meetings/recordings/" + meetings_id
end

def test_info_method
Expand Down
4 changes: 2 additions & 2 deletions test/vonage/meetings/rooms_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ def rooms
end

def rooms_uri
"https://" + meetings_host + "/meetings/rooms"
"https://" + meetings_host + "/v1/meetings/rooms"
end

def room_uri
"https://" + meetings_host + "/meetings/rooms/" + meetings_id
"https://" + meetings_host + "/v1/meetings/rooms/" + meetings_id
end

def test_list_method
Expand Down
2 changes: 1 addition & 1 deletion test/vonage/meetings/sessions_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ def sessions
end

def sessions_uri
"https://" + meetings_host + "/meetings/sessions/" + meetings_id +
"https://" + meetings_host + "/v1/meetings/sessions/" + meetings_id +
"/recordings"
end

Expand Down
4 changes: 2 additions & 2 deletions test/vonage/meetings/themes_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ def themes
end

def themes_uri
"https://" + meetings_host + "/meetings/themes"
"https://" + meetings_host + "/v1/meetings/themes"
end

def theme_uri
"https://" + meetings_host + "/meetings/themes/" + meetings_id
"https://" + meetings_host + "/v1/meetings/themes/" + meetings_id
end

def list_response
Expand Down

0 comments on commit 9372157

Please sign in to comment.