Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVX-6439: Update Messages API Template Message class #242

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

superchilled
Copy link
Contributor

Reason for this PR

Due to an error in the Messages API spec for the WhatsApp Template type message, the SDK tested for the presence of the policy property in the whatsapp object of the WhatsApp Template message type. The spec incorrectly had this property as required, but it is in fact optional. See this JIRA ticket for additional context

This PR updated the Ruby SDK to remove a check that validates for the presence of that property.

What this PR does

  • Updates the Messaging::Channels::WhatsApp#verify_message method to remove a validation check for the required presence of opts[:whatsapp][:policy]
  • Removes the test associated with this validation logic from Messaging::Channels::WhatsAppTest

@superchilled superchilled merged commit 87841d4 into dev Aug 25, 2022
@superchilled superchilled mentioned this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants