Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVX-6418: Adding Voice NCCO Pay action #244

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

superchilled
Copy link
Contributor

Reason for this PR

The NCCO reference has added an action for Pay, which therefore needed to be implemented in the Ruby SDK.

What this PR does

  • Defines an NCCO Pay action under Voice::Actions
  • Adds tests for this new action

@codecov-commenter
Copy link

Codecov Report

Merging #244 (59a7fd2) into dev (0c4059b) will increase coverage by 0.02%.
The diff coverage is 98.24%.

❗ Current head 59a7fd2 differs from pull request most recent head 442b079. Consider uploading reports for the commit 442b079 to get more accurate results

@@            Coverage Diff             @@
##              dev     #244      +/-   ##
==========================================
+ Coverage   97.71%   97.73%   +0.02%     
==========================================
  Files          70       71       +1     
  Lines        1400     1457      +57     
==========================================
+ Hits         1368     1424      +56     
- Misses         32       33       +1     
Impacted Files Coverage Δ
lib/vonage/voice/actions/pay.rb 98.24% <98.24%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@superchilled superchilled merged commit b1dffd1 into dev Sep 6, 2022
@superchilled superchilled deleted the devx-6418-add-voice-ncco-pay-action branch September 6, 2022 10:01
@superchilled superchilled mentioned this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants