Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVX-6472: Adding more Verify tests for Blacklist error response #246

Merged
merged 2 commits into from
Sep 6, 2022

Conversation

superchilled
Copy link
Contributor

Reason for this PR

The Verify API has a new possible error response for the https://api.nexmo.com/verify/json, which can return a response with and without certain properties in the response body. This PR is to ensure that the existing implementation of Verify in the Ruby SDK handles the various permutations of this response correctly. See this JIRA ticket for additional context.

What this PR does

  • Following the addition of the tests for the verify endpoint already added in DEVX-6472: Adding Verify tests for Blacklist error response #241, this PR adds three more tests to verify_test.rb for the for psd2 endpoint:
    • One to check an blacklist error response for psd2 endpoint with network but not request_id
    • One to check an blacklist error response for psd2 endpoinwith request_id but not network
    • One to check an blacklist error response for psd2 endpoinwith request_id and network

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Merging #246 (fe1b55d) into dev (0c4059b) will not change coverage.
The diff coverage is n/a.

❗ Current head fe1b55d differs from pull request most recent head 00aca9d. Consider uploading reports for the commit 00aca9d to get more accurate results

@@           Coverage Diff           @@
##              dev     #246   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files          70       70           
  Lines        1400     1400           
=======================================
  Hits         1368     1368           
  Misses         32       32           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@superchilled superchilled merged commit 579c9de into dev Sep 6, 2022
@superchilled superchilled deleted the devx-6466-verify-blacklist-response-more-tests branch September 6, 2022 09:59
@superchilled superchilled mentioned this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants