Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVX-7907: Update Verify2 Silent Authentication workflow options #300

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

superchilled
Copy link
Contributor

@superchilled superchilled commented Dec 3, 2023

This PR updates the available options for a Verify v2 Silent Authentication workflow. Specifically it:

  • Updates Verify2::Channels::SilentAuth:
    • Sets redirect_url and sandbox ivars in #initialize
    • Defines custom setter methods for the two new ivars (with input validation)
    • Defines getter methods for the two new ivars (via attr_reader)
  • Adds/updates tests for the above implemention
  • Some additional refactoring/ improvements for other channels

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1da0593) 97.94% compared to head (9adeea8) 97.95%.

❗ Current head 9adeea8 differs from pull request most recent head d3ffd54. Consider uploading reports for the commit d3ffd54 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   97.94%   97.95%           
=======================================
  Files         108      108           
  Lines        1999     2008    +9     
=======================================
+ Hits         1958     1967    +9     
  Misses         41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@SecondeJK SecondeJK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possible changes, def not essential

lib/vonage/verify2/channels/silent_auth.rb Outdated Show resolved Hide resolved
lib/vonage/verify2/channels/silent_auth.rb Outdated Show resolved Hide resolved
@superchilled superchilled marked this pull request as ready for review December 8, 2023 09:54
@superchilled superchilled merged commit 88a87c6 into main Dec 8, 2023
17 checks passed
@superchilled superchilled deleted the devx-7907-update-verify-silent-auth branch December 8, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants