VIDSOL-105: Background Replacement Support for Web VERA - Custom Images #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with unified management in preview and meeting rooms. Refactored publisher logic, updated user context, and enhanced UI to support and display background selections.
…dded isParentVideoEnabled prop, standardized option sizing, and improved disabled video container styles.
OscarFava
changed the title
cpettet
reviewed
Sep 22, 2025
frontend/src/components/BackgroundEffects/BackgroundEffectTabs/BackgroundEffectTabs.spec.tsx
Show resolved
Hide resolved
frontend/src/components/BackgroundEffects/BackgroundEffectTabs/BackgroundEffectTabs.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/BackgroundEffects/SelectableOption/SelectableOption.tsx
Show resolved
Hide resolved
| mode: 'meeting' | 'waiting'; | ||
| }; | ||
|
|
||
| const BackgroundEffectsLayout = ({ |
There was a problem hiding this comment.
Could we add jsdoc for this component?
There was a problem hiding this comment.
I believe we're still missing the jsdoc here but the comment was shown as resolved 🙏
frontend/src/components/BackgroundEffects/BackgroundEffectsLayout/BackgroundEffectsLayout.tsx
Show resolved
Hide resolved
behei-vonage
previously approved these changes
Sep 23, 2025
|
Hey @OscarFava, It looks 🤩 BG replacement desktop:
Mobile view:
|
…und-replacement-custom-images
…or viewport handling with custom hook
OscarFava
dismissed stale reviews from behei-vonage and cpettet
via
81fa0d3
...oundEffects/AddBackgroundEffect/AddBackgroundEffectLayout/AddBackgroundEffectLayout.spec.tsx
Outdated
Show resolved
Hide resolved
...nd/src/components/BackgroundEffects/BackgroundEffectsLayout/BackgroundEffectsLayout.spec.tsx
Outdated
Show resolved
Hide resolved
| mode: 'meeting' | 'waiting'; | ||
| }; | ||
|
|
||
| const BackgroundEffectsLayout = ({ |
There was a problem hiding this comment.
I believe we're still missing the jsdoc here but the comment was shown as resolved 🙏
frontend/src/components/BackgroundEffects/FileUploader/FileUploader.spec.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/BackgroundEffects/FileUploader/FileUploader.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/BackgroundEffects/SelectableOption/SelectableOption.tsx
Outdated
Show resolved
Hide resolved
…age, and enhance component documentation
|
Tested LGTM!! 🚀 |
cpettet
reviewed
Sep 30, 2025
frontend/src/components/BackgroundEffects/BackgroundGallery/BackgroundGallery.tsx
Show resolved
Hide resolved
...ackgroundEffects/AddBackgroundEffect/AddBackgroundEffectLayout/AddBackgroundEffectLayout.tsx
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
This PR is adding the capability to add custom images that will be used to replace the background of the publisher.
How should this be manually tested?
1- Enter to waiting room, click "Background Effects" button on the bottom corner.
1.1 - Test tab "backgrounds". Select different backgrounds that will be applied on the publisher. If you "cancel", that background will not be applied to the main publisher, if you click "apply", it will be applied.
1.2 - Click tab "Add Background" and add a custom image. Then, do same as step 1.1 with that custom image.
2- Enter to meeting room and click on the button next to the camera (video devices) and then click "Background Effects".
2.2 - Do the same as 1.1 and 1.2
What are the relevant tickets?
A maintainer will add this ticket number.
Resolves VIDSOL-105
Checklist
[ ] Branch is based on
develop(notmain).[ ] Resolves a
Known Issue.[ ] If yes, did you remove the item from the
docs/KNOWN_ISSUES.md?[ ] Resolves an item reported in
Issues.If yes, which issue? Issue Number?