VIDSOL-134: add route to assetlinks json file #202
Conversation
manolovn
changed the title
backend/.well-known/assetlinks.json
Outdated
| @@ -0,0 +1,9 @@ | |||
| [{ | |||
| "relation": ["delegate_permission/common.handle_all_urls"], | |||
There was a problem hiding this comment.
It's not obvious what the relation properties listed provide us. Since this is a JSON file, we don't have a good way of inlining documentation either.
Is there a way for us to document why the non-obvious properties have the value they do? Naively, maybe we can document them in the integration test you added?
There was a problem hiding this comment.
Thinking about this some more, you can probably make this a plain object or refactor as a getter that returns a plain object. Then, you can add comments, as needed.
The endpoint you created below can handle the serialization and return the expected JSON.
There was a problem hiding this comment.
changes done here 11d3528
| assetLinksRouter.get('/assetlinks.json', (_req: Request, res: Response) => { | ||
| res.json([ | ||
| { | ||
| // Grants the target permission to handle all URLs that the source can handle |
backend/routes/assetlinks.ts
Outdated
| const assetLinksRouter = Router(); | ||
|
|
||
| /** | ||
| * tl:dr: Serve the static file needed for mobile deep linking |
There was a problem hiding this comment.
tl:dr: implies that this will be preceded or proceeded by a more verbose explanation. Since there is none, how do you feel about dropping it (and leaving "Serve the ...")?
There was a problem hiding this comment.
changed here 568248a
manolovn
force-pushed
the
deeplink-android-support
branch
2 times, most recently
from
4e43d6b to
42e7e59
Compare
manolovn
force-pushed
the
deeplink-android-support
branch
from
42e7e59 to
5b92bcd
Compare
|
What is this PR doing?
Serve the static file
assetlinks.jsonin the URL{baseUrl}/.well-known/assetlinks.jsonfollowing the documentation https://developer.android.com/training/app-links/verify-android-applinks#publish-jsonHow should this be manually tested?
N/A -- make sure CI passes (since an integration test was added)
What are the relevant tickets?
Resolves VIDSOL-134
Checklist
develop(notmain).Known Issue.docs/KNOWN_ISSUES.md?Issues.If yes, which issue? Issue Number?