VIDSOL-149: Camera light stays on after toggling video off #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
v-kpheng
approved these changes
Aug 27, 2025
| expect(screen.getByTestId('ArrowDropUpIcon')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('updates the main publisher and the background replacement publisher when clicked', () => { |
There was a problem hiding this comment.
Nit: "updates" -> "toggles" ?
| expect(screen.getByTestId('VideocamOffIcon')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('updates the main publisher and the background replacement publisher when clicked', () => { |
There was a problem hiding this comment.
Same nit here: "updates" -> "toggles" 🤷♂️
|
Tested LGTM!! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
This PR fixes an issue where a webcam light stays on when toggling video off. This happens due to now using two different publishers, one of which was not being changed when toggling the video off.
How should this be manually tested?
To reproduce the issue, follow these steps:
developbranch.To reproduce the fix, follow the steps above on this PRs' branch and notice that the issue is no longer reproducible.
What are the relevant tickets?
A maintainer will add this ticket number.
Resolves VIDSOL-149
Checklist
[ ] Branch is based on
develop(notmain).[ ] Resolves a
Known Issue.[ ] If yes, did you remove the item from the
docs/KNOWN_ISSUES.md?[ ] Resolves an item reported in
Issues.If yes, which issue? Issue Number?