Skip to content

VIDSOL-51: Incorrect running instructions for ngrok #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 15, 2025
Merged

VIDSOL-51: Incorrect running instructions for ngrok #212

merged 7 commits into from
Sep 15, 2025

Conversation

@behei-vonage
Copy link
Contributor

@behei-vonage behei-vonage commented Sep 5, 2025

What is this PR doing?

This PR fixes an issue where if one follows the instructions in README.md on how to test the app via ngrok, one won't have any luck with it.

How should this be manually tested?

To reproduce the issue:

  • Checkout the develop branch.
  • Follow the steps in README.md that show how to do Testing on Multiple Devices.
  • Notice that you're getting a token error when joining the meeting room. 😢

To reproduce the fix:

  • Checkout this branch.
  • Follow the steps in the README.md that show how to do Testing on Multiple Devices.
  • Notice that you are able to do so.

What are the relevant tickets?

A maintainer will add this ticket number.

Resolves VIDSOL-51

Checklist

[ ] Branch is based on develop (not main).
[ ] Resolves a Known Issue.
[ ] If yes, did you remove the item from the docs/KNOWN_ISSUES.md?
[ ] Resolves an item reported in Issues.
If yes, which issue? Issue Number?

@behei-vonage behei-vonage self-assigned this Sep 5, 2025
cpettet
cpettet reviewed Sep 8, 2025
View reviewed changes
Copy link
Contributor

@cpettet cpettet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Just have a few comments/questions. Let me know what you think!

@behei-vonage @cpettet
simplify
1fa7604 
Co-authored-by: Christian Pettet <cpettet11@gmail.com>
@behei-vonage behei-vonage requested a review from cpettet September 8, 2025 17:33
v-kpheng
v-kpheng reviewed Sep 10, 2025
View reviewed changes
Copy link
Contributor

@v-kpheng v-kpheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 💪

That said, left some questions/comments. Thanks 🙏

v-kpheng
v-kpheng previously approved these changes Sep 12, 2025
View reviewed changes
Copy link
Contributor

@v-kpheng v-kpheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💪 🚀

That said, please see note about the typo. Thanks 🙏

v-kpheng
v-kpheng previously approved these changes Sep 12, 2025
View reviewed changes
Copy link
Contributor

@v-kpheng v-kpheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💪 🚀

v-kpheng
v-kpheng previously approved these changes Sep 12, 2025
View reviewed changes
Copy link
Contributor

@v-kpheng v-kpheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💪 🚀

cpettet
cpettet reviewed Sep 12, 2025
View reviewed changes
Copy link
Contributor

@cpettet cpettet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Just have a few comments/questions. Let me know what you think!

@behei-vonage @cpettet
Update README.md
2ad651f 
Co-authored-by: Christian Pettet <cpettet11@gmail.com>
@behei-vonage @cpettet
Update README.md
a7165ca 
Co-authored-by: Christian Pettet <cpettet11@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 12, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

cpettet
cpettet approved these changes Sep 12, 2025
View reviewed changes
Copy link
Contributor

@cpettet cpettet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Great job! :shipit:

v-kpheng
v-kpheng approved these changes Sep 12, 2025
View reviewed changes
Copy link
Contributor

@v-kpheng v-kpheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💪 🚀

@dwivedisachin
Copy link
Contributor

dwivedisachin commented Sep 15, 2025

Tested LGTM!! 🚀🤩

@behei-vonage behei-vonage merged commit 1c25238 into develop Sep 15, 2025
7 checks passed
@behei-vonage behei-vonage deleted the behei-vonage/vidsol-51-ngrok branch September 15, 2025 17:21
behei-vonage added a commit that referenced this pull request Sep 17, 2025
@behei-vonage @cpettet
VIDSOL-51: Incorrect running instructions for ngrok (#212)
c74aedf 
Co-authored-by: Christian Pettet <cpettet11@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@v-kpheng v-kpheng v-kpheng approved these changes

@cpettet cpettet cpettet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@behei-vonage behei-vonage

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@behei-vonage @dwivedisachin @v-kpheng @cpettet