Skip to content

Conversation

@OscarFava
Copy link
Contributor

What is this PR doing?

This PR is passing the current state of camera and mic when calling change background.

How should this be manually tested?

Disable camera and mic. Open Backgrounds Effects and change to another background. (Camera and mic remain unchanged). Then, enable camera again to see the recent selected background.

What are the relevant tickets?

A maintainer will add this ticket number.

Resolves VIDSOL-144

Checklist

[ ] Branch is based on develop (not main).
[ ] Resolves a Known Issue.
[ ] If yes, did you remove the item from the docs/KNOWN_ISSUES.md?
[ ] Resolves an item reported in Issues.
If yes, which issue? Issue Number?

Copy link
Contributor

@cpettet cpettet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Just have a few comments/questions. Let me know what you think!

@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

Copy link
Contributor

@cpettet cpettet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Great job! :shipit:

Copy link
Contributor

@behei-vonage behei-vonage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@dwivedisachin
Copy link
Contributor

Tested LGTM!! 🚀

@dwivedisachin dwivedisachin merged commit 0250eb2 into develop Sep 16, 2025
7 checks passed
@dwivedisachin dwivedisachin deleted the vidsol-144/mic-camera-toggled-back-when-change-background branch September 16, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants