-
Notifications
You must be signed in to change notification settings - Fork 10
VIDSOL-212: background replacement translations #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VIDSOL-212: background replacement translations #238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM, just a small question for one of the unit tests
frontend/src/components/BackgroundEffects/BackgroundGallery/BackgroundGallery.spec.tsx
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bugs were introduced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per discussion with Oscar:
- New York is a valid Italian translation
- Firefox works as expected





What is this PR doing?
This PR is translating background effects.
How should this be manually tested?
Check if translated texts do not overflow content. To change a language, you will need to change your browser language (only check english, spanish and italian).
What are the relevant tickets?
A maintainer will add this ticket number.
Resolves VIDSOL-212
Checklist
[X] Branch is based on
develop(notmain).[ ] Resolves a
Known Issue.[ ] If yes, did you remove the item from the
docs/KNOWN_ISSUES.md?[ ] Resolves an item reported in
Issues.If yes, which issue? Issue Number?