Skip to content

Conversation

@OscarFava
Copy link
Contributor

@OscarFava OscarFava commented Oct 7, 2025

What is this PR doing?

This PR is translating background effects.

How should this be manually tested?

Check if translated texts do not overflow content. To change a language, you will need to change your browser language (only check english, spanish and italian).

What are the relevant tickets?

A maintainer will add this ticket number.

Resolves VIDSOL-212

Checklist

[X] Branch is based on develop (not main).
[ ] Resolves a Known Issue.
[ ] If yes, did you remove the item from the docs/KNOWN_ISSUES.md?
[ ] Resolves an item reported in Issues.
If yes, which issue? Issue Number?

@OscarFava OscarFava changed the title Translate BG replacement VIDSOL-212: background replacement translations Oct 7, 2025
Copy link
Contributor

@behei-vonage behei-vonage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, just a small question for one of the unit tests

@OscarFava OscarFava requested a review from behei-vonage October 8, 2025 08:27
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2025

Copy link
Contributor

@behei-vonage behei-vonage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Copy link
Contributor

@VZaphod VZaphod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rserebrennykov
Copy link

rserebrennykov commented Oct 22, 2025

i have found a list of moments here:

  • Italian New York wasn't translated
image
  • Firefox doesn't have background button
image

Copy link

@rserebrennykov rserebrennykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bugs were introduced

Copy link

@rserebrennykov rserebrennykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per discussion with Oscar:

  • New York is a valid Italian translation
  • Firefox works as expected

@OscarFava OscarFava merged commit 40eca76 into develop Oct 22, 2025
8 checks passed
@OscarFava OscarFava deleted the vidsol-212/background-replacement-translate branch October 22, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants