-
Notifications
You must be signed in to change notification settings - Fork 10
VIDSOL-208: Language selector #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
6dafa41
Copied code
OscarFava f1a8dba
Commit screenshot file: integration-tests/tests/visualComparisons.spe…
github-actions[bot] 6cdf55f
Commit screenshot file: integration-tests/tests/visualComparisons.spe…
github-actions[bot] 1a257a9
Commit screenshot file: integration-tests/tests/visualComparisons.spe…
github-actions[bot] af92924
Commit screenshot file: integration-tests/tests/visualComparisons.spe…
github-actions[bot] f4c56e2
Commit screenshot file: integration-tests/tests/visualComparisons.spe…
github-actions[bot] ef17a2e
Commit screenshot file: integration-tests/tests/visualComparisons.spe…
github-actions[bot] 417b8de
Commit screenshot file: integration-tests/tests/visualComparisons.spe…
github-actions[bot] 96e252d
Commit screenshot file: integration-tests/tests/visualComparisons.spe…
github-actions[bot] da0f39b
Commit screenshot file: integration-tests/tests/visualComparisons.spe…
github-actions[bot] 6a2a6f2
Commit screenshot file: integration-tests/tests/visualComparisons.spe…
github-actions[bot] 782ec4a
Commit screenshot file: integration-tests/tests/visualComparisons.spe…
github-actions[bot] 9ad17d5
Commit screenshot file: integration-tests/tests/visualComparisons.spe…
github-actions[bot] 699b044
Commit screenshot file: integration-tests/tests/visualComparisons.spe…
github-actions[bot] 1957e4c
Commit screenshot file: integration-tests/tests/visualComparisons.spe…
github-actions[bot] 14a387e
Commit screenshot file: integration-tests/tests/visualComparisons.spe…
github-actions[bot] a04541d
Commit screenshot file: integration-tests/tests/visualComparisons.spe…
github-actions[bot] ae7cb64
Commit screenshot file: integration-tests/tests/visualComparisons.spe…
github-actions[bot] c5b992d
Commit screenshot file: integration-tests/tests/visualComparisons.spe…
github-actions[bot] 854bb91
Fix vulnerability vivid
OscarFava f0e330a
Do not show video after re-rendering if video is not enabled
OscarFava 4a30dd5
Fix unit test
OscarFava c6585ad
Update readme
OscarFava 69a2b83
Update readme
OscarFava 3ed6ac6
Merge branch 'develop' into ofava/vidsol-208-lang-selector
OscarFava 6c8ec04
Update readme
OscarFava 57d6264
Update readme
OscarFava 6b6a870
Update README.md
OscarFava File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
frontend/src/components/BannerLanguage/BannerLanguage.spec.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { describe, expect, it } from 'vitest'; | ||
| import { render, screen } from '@testing-library/react'; | ||
| import { MemoryRouter } from 'react-router-dom'; | ||
| import BannerLanguage from './BannerLanguage'; | ||
|
|
||
| describe('BannerLanguage', () => { | ||
| it('renders the banner language component', () => { | ||
| render( | ||
| <MemoryRouter> | ||
| <BannerLanguage /> | ||
| </MemoryRouter> | ||
| ); | ||
|
|
||
| const bannerLanguage = screen.getByTestId('banner-language'); | ||
| expect(bannerLanguage).toBeInTheDocument(); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import { ReactElement } from 'react'; | ||
| import LanguageSelector from '../LanguageSelector'; | ||
|
|
||
| /** | ||
| * BannerLanguage Component | ||
| * | ||
| * This component provides a language selection feature for the banner. | ||
| * @returns {ReactElement} The BannerLanguage component. | ||
| */ | ||
| const BannerLanguage = (): ReactElement => { | ||
| return ( | ||
| <div className="flex items-center" data-testid="banner-language"> | ||
| <LanguageSelector /> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default BannerLanguage; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| import BannerLanguage from './BannerLanguage'; | ||
|
|
||
| export default BannerLanguage; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.