Skip to content

Conversation

@behei-vonage
Copy link
Contributor

@behei-vonage behei-vonage commented Oct 14, 2025

What is this PR doing?

This PR adds a precall test page that the user is taken to after creating a room or joining a random room name.
The users will have an option to either Test their device access / connection, or go straight to the waiting room.

How should this be manually tested?

Checkout this branch.
Join the landing page, click on "create room".
Notice a new page where you have an option to Test connectivity to your devices, check video / audio quality, or go straight to the waiting room.
Check this on mobile devices, too.

Note: this is based on the Vonage Unified version of the opentok-network-test-js. For the precall test to work correctly, please test this with vonage being your video service provider, not opentok.

What are the relevant tickets?

A maintainer will add this ticket number.

Resolves VIDSOL-248

Checklist

[ ] Branch is based on develop (not main).
[ ] Resolves a Known Issue.
[ ] If yes, did you remove the item from the docs/KNOWN_ISSUES.md?
[ ] Resolves an item reported in Issues.
If yes, which issue? Issue Number?

@behei-vonage behei-vonage self-assigned this Oct 14, 2025
@behei-vonage behei-vonage added do-not-merge Do Not Merge do-not-review Do not review labels Oct 14, 2025
@behei-vonage behei-vonage removed do-not-merge Do Not Merge do-not-review Do not review labels Oct 14, 2025
@VZaphod VZaphod requested a review from Copilot October 15, 2025 06:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new PreCall Test page that users navigate to after creating or joining a room, allowing them to test their device connectivity, video/audio quality, and network connection before entering the waiting room.

Key changes include:

  • Addition of a comprehensive pre-call testing system with network connectivity and quality tests
  • Integration of the Vonage Video network test library for device and connection validation
  • Updated navigation flow to route users through the pre-call test page before the waiting room

Reviewed Changes

Copilot reviewed 32 out of 33 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
integration-tests/tests/landing.spec.ts Updates test expectations to include the new precall navigation flow
frontend/src/pages/PreCallTest/ New page component with network testing functionality and comprehensive test coverage
frontend/src/hooks/useNetworkTest.tsx Custom hook implementing network connectivity and quality testing with Vonage Video API
frontend/src/components/PreCall/ Complete set of UI components for displaying test progress, results, errors, and controls
frontend/src/locales/*.json Internationalization strings for the precall test feature in multiple languages
frontend/src/components/RoomJoinContainer/RoomJoinContainer.tsx Updates room creation flow to navigate to precall instead of waiting room
frontend/src/components/JoinButton/JoinButton.tsx Updates join button to navigate to precall page
frontend/src/App.tsx Adds new route for the precall test page
frontend/package.json Adds dependency for Vonage video network test library

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@OscarFava OscarFava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing Job 🥳 🥳 @behei-vonage!
@VZaphod and I were thinking about the flow that adds this PR. We see that it could be a little intrusive for the user to force him to go trough this preCall page. Maybe we could discuss it togheter. 🙏
Pd: I have added some suggestions due to the new changes in customize theme (217) and other minor comments!
Thanks a lot for the job! 🙏 🙏

@VZaphod VZaphod changed the title VIDSOL-0000: Add PreCall Test page VIDSOL-248: Add PreCall Test page Oct 16, 2025
@behei-vonage behei-vonage added the update-screenshots Run update screenshots CI workflow label Oct 16, 2025
Copy link
Contributor

@OscarFava OscarFava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!!!

@behei-vonage behei-vonage added the update-screenshots Run update screenshots CI workflow label Oct 17, 2025
@behei-vonage behei-vonage reopened this Oct 17, 2025
…c.ts-snapshots/Waiting-page-UI-test-1-Electron-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Google-Chrome-Fake-Devices-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Microsoft-Edge-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Mobile-Chrome-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Opera-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-firefox-linux.png
OscarFava
OscarFava previously approved these changes Oct 20, 2025
Copy link
Contributor

@OscarFava OscarFava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work 🚀 👏

@OscarFava OscarFava removed the update-screenshots Run update screenshots CI workflow label Oct 20, 2025
@OscarFava OscarFava self-requested a review October 23, 2025 07:17
OscarFava
OscarFava previously approved these changes Oct 23, 2025
Copy link
Contributor

@OscarFava OscarFava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@behei-vonage behei-vonage added the update-screenshots Run update screenshots CI workflow label Oct 31, 2025
@sonarqubecloud
Copy link

…c.ts-snapshots/Waiting-page-UI-test-1-Opera-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Electron-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Google-Chrome-Fake-Devices-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Microsoft-Edge-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Mobile-Chrome-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-firefox-linux.png
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

update-screenshots Run update screenshots CI workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants