Skip to content

Conversation

@OscarFava
Copy link
Contributor

@OscarFava OscarFava commented Oct 17, 2025

What is this PR doing?

This PR is fixing ghost user where he sees every other publisher but nobody sees him (he is not being able to publish). In order to reproduce this error, we should force in node_modules/@vonage/client-sdk-video/dist/js/opentok.js

publishToSession: (session, analyticsReplacement) => {
        if(window.fail){
          return Promise.reject(new Error("Failed to publish to session"));
        }

How should this be manually tested?

What are the relevant tickets?

A maintainer will add this ticket number.

Resolves VIDSOL-246

Checklist

[X] Branch is based on develop (not main).
[ ] Resolves a Known Issue.
[ ] If yes, did you remove the item from the docs/KNOWN_ISSUES.md?
[ ] Resolves an item reported in Issues.
If yes, which issue? Issue Number?

@OscarFava OscarFava changed the title Fix VIDSOL-246: I was in call but other people can't see me and I was able to see everyone. Oct 17, 2025
@sonarqubecloud
Copy link

Copy link
Contributor

@behei-vonage behei-vonage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! great job solving this tough riddle 💪

@OscarFava OscarFava requested a review from VZaphod October 20, 2025 14:57
Copy link
Contributor

@VZaphod VZaphod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! 🚀🚀

Copy link

@rserebrennykov rserebrennykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested - LGTM

@OscarFava OscarFava merged commit 1a694e0 into develop Oct 23, 2025
7 checks passed
@OscarFava OscarFava deleted the ofava/vidsol-246-ghost-pub branch October 23, 2025 11:41
@OscarFava OscarFava restored the ofava/vidsol-246-ghost-pub branch October 23, 2025 11:41
@OscarFava OscarFava deleted the ofava/vidsol-246-ghost-pub branch October 23, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants