Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ukrainian and Russian localisations #74

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

ghost
Copy link

@ghost ghost commented Dec 31, 2023

I unable to test translations for editor because I can't even run project, it throws error:

Trying to assign value of type 'Nil' to a variable of type 'Dictionary'.

in

0 - res://ui/editor_window/editor_layout.gd:18 - at function load_editor_layout
1 - res://ui/editor_window/editor_layout.gd:7 - at function _ready

this line:

var data: Dictionary = data_file.get_var()

But since there not much strings to begin with and they are generic enough, I don't think I translated something THAT wrong.

However, I tested startup window and there everything should be fine.

Also, it's not related to pull, but adding information in readme file about what version of Godot currently used in project will be quite handy, especially for someone like me who jumps to more up-to-date builds of Godot rather then staying on stable versions.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your time to help us improve GoZen, we really appreciate your efforts!

@ghost ghost changed the title Add Ukrainian and Russia localisations Add Ukrainian and Russian localisations Dec 31, 2023
@voylin
Copy link
Collaborator

voylin commented Jan 2, 2024

Thank you for the translations!

At this moment the editor is still under very heavy development and it is possible that the current uploaded stuff does not work as I am working on many things at the moment which will each get uploaded separately. The Alpha is supposed to be out around February so it will still take some time before we have an actual working editor.

During alpha we will be going through the translations and many strings will get added as adding translation strings is not a priority right now.

I'll add your name to the language contributor list and merge this pull request. ;)

@voylin voylin merged commit e63c451 into VoylinsGamedevJourney:master Jan 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant