Use vulcan-ui-bootstrap (issue #50)

[kabalin]

Here are the patches for example-forms and example-membership. @SachaG I am not sure if you done example-forum already, if not forum patches will follow here.

[kabalin]

One issue I came across though, is that adding vulcan:ui-bootstrap to package.js in example package results in a error that ui-bootstrap package is not found. Using meteor add vulcan:ui-bootstrap results in a same error. This is clearly not the case for other vulcan:* packages used in package.js in other examples, e.g. example-forum imports many different vulcan packages. I am using two-repos mode with METEOR_PACKAGE_DIRS env pointing to ../Vulcan/packages location.

I only managed to resolve the issue by specifying vulcan:ui-bootstrap explicitly in .meteor/packages, i.e.

diff --git a/.meteor/packages b/.meteor/packages
index 6590856..b9151ab 100644
--- a/.meteor/packages
+++ b/.meteor/packages
@@ -1,6 +1,7 @@
 # see http://docs.vulcanjs.org/packages
 
 vulcan:core@1.9.0
+vulcan:ui-bootstrap@1.9.1

Not sure if this is something with my setup, or am I missing something?

[kabalin]

Added patch for example-forum without Dropdown and Modal refactoring yet.

[SachaG]

I only managed to resolve the issue by specifying vulcan:ui-bootstrap explicitly in .meteor/packages, i.e.

Yes, I've been running into the same issue. I think it's a problem with Meteor's package management system.

In this specific case though we don't want to add the dependency in the example package's package.js files though, since that would mean users wouldn't be able to switch from bootstrap to other UI frameworks without modifying the file. So putting it in .meteor/packages is the right move I think.

I'll wait until you're finished with the dropdown/modal stuff to merge. Don't hesitate to ping me on Slack if the dropdown stuff is confusing btw :)

[kabalin]

In this specific case though we don't want to add the dependency in the example package's package.js files though, since that would mean users wouldn't be able to switch from bootstrap to other UI frameworks without modifying the file. So putting it in .meteor/packages is the right move I think.

In fact, I would keep reference to ui-bootstrap in example package's package.js. You know, these packages are "examples" by defintion, someone willing to use other UI framework probably would end up modifying the code anyway. Though, I can remove package.js changes from the patches if you wish.

I looked closer at modal and have got a question. UsersProfileCheck.jsx has Modal.Footer, while Components.ModalTrigger does not have one. Shall I make ModalTrigger to support footer or move its content to body when migrating to Components.ModalTrigger (or even remove footer content completely)?

[SachaG]

You know, these packages are "examples" by defintion, someone willing to use other UI framework probably would end up modifying the code anyway.

Yes, that's a good point as well. Let's leave it in package.js for now then.

Shall I make ModalTrigger to support footer or move its content to body when migrating to Components.ModalTrigger (or even remove footer content completely)?

Let's remove the footer for now then. We can start simple and always add more features if they're needed in more than one place.

[kabalin]

The Modal patch 4b58510 depends on VulcanJS/Vulcan#1971 In fact, I kept footer since I ended up adding a separate component for modal.

Dropdown changes will follow later this week.

[SachaG]

Can you push what you have so far? I can take care of the rest :)

[kabalin]

@SachaG I did not touch Dropdown code yet to be honest (steep learning curve you know), so there are no pending changes. All I have done so far is pushed, so feel free to take it over from here if you wish :)

[SachaG]

OK, I'll try to do the dropdown stuff today then. Thanks for your work so far!