Bugfix/nested objects b34f0a25ce0c775a29a14241b14e9bc0e47976c8 #2022
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested form wouldn't work anymore.
This was due to the field retrieval methods (
getMutableFields
,getInsetableFields
) using systematicallythis.state.schema
as the current schema. But when you want the fields of a nested schema, you need to pass it explicitely. Same forcreateField
.value
prop of theFormNested
was not defined either, instead the wholecurrentValues
object is passed.However this fix needs a review, I am not sure what was the intent of the previous modifications on the
Form
component.I also added a few tests (that does almost nothing), so that we start taking good habits :)
Unit testing is a bit complex and heavy because we need to run Meteor even for pure frontend testing, and Mocha have less features than Jest. But a few regression tests are never a bad thing.
It would also be a good idea to write a few acceptance tests on the Vulcan Starter app with Chimp to detect such issues more easily.