Collected fixes (#509, #575) #589
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 31, 2015 20:26
- rename s:check_bundle_name to s:register_bundle_name, it has the side-effect of updating the bundle name registry - expand possible return values - re-registering a plugin name for the same bundle is no conflict - don't continue processing plugins if registration fails
- ensure that all system calls go via installer.vim (vundle#installer#system, used to be s:system) - escape/wrap complex command sequences - log commands before trying to execute them
|
Note discussion/testing in #575, especially the relevant vim patches referred to in https://github.com/airblade/vim-system-escape. |
- only test for os, vim version and patch level once - on old vims, only wrap system argument for cmd.exe
|
Any chance of merging this soon? |
|
I think most fixes are going to be waiting until #619 (at least some first basic tests) |
|
Thanks for the info! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related PR: #586
Note: if you prefer your fixes separated, you can just pick the first commit from this branch for #509 and pull from branch fix_system_calls_on_windows for #575.