Address Banner and MREC ad display issue. #6
Conversation
This commit will update the show ad for Banner/Mrec to be called after the ad finishes downloading the assets. Also updates the finish display ad to be called on destroy. IOS-5559 IOS-5560
ManojBudumuru-vungle
requested review from
crbinsf,
ashinagawa,
YueVungle,
stanley-vungle and
bobVungle
There was a problem hiding this comment.
I could verify that IOS-5559 has been fixed. Banner and MREC are displayed after fresh install.
But, I still see the IOS-5560 issue.
After displaying MREC first time, and go back to main screen, then go to "MRECs> AutoLayout MRECs" and no MREC displayed this time.
There was a problem hiding this comment.
LGTM
@ashinagawa @ManojBudumuru-vungle I displayed the Vungle MREC Ad after the first time MREC Ad played. But for MREC Ads, I got Applovin ads most of the time. Thnanks :)
|
Test again. For MREC Ads, still got Applovin ads most of the time. Thanks :) |
|
Are you using a physical device? If I use the Simulator, I only get AppLovin ads, but on a physical device, I can get vungle ads. |
| @@ -140,7 +141,14 @@ - (void)destroy | |||
| if ( self.adView ) | |||
| { | |||
| // Note: Not calling this for now because it clears pre-loaded/cached ad view ads as well. | |||
| // [[VungleSDK sharedSDK] finishedDisplayingAd]; | |||
| if (self.bidResponse) { | |||
There was a problem hiding this comment.
Need to add spaces and move the brace to the other line to follow MAX standards
There was a problem hiding this comment.
Line 1122：
MANativeAd *maxNativeAd = [[MAVungleNativeAd alloc] initWithParentAdapter: self.parentAdapter builderBlock:^(MANativeAdBuilder *builder) {
builder.title = nativeAd.title;
builder.body = nativeAd.bodyText;
Might need to move the brace to the other line to keep the format consistent. Thanks. :)
@stanley-vungle Thanks a lot for the reminder, changed to device. :) |
| { | ||
| self.adViewbidResponseDict = [[NSMutableDictionary alloc] init]; | ||
| } | ||
| self.adViewbidResponseDict[self.placementIdentifier] = bidResponse; |
There was a problem hiding this comment.
@ManojBudumuru-vungle Tested on the device, for bidding banner, failed to load ad with the error:
2022-11-11 17:17:18.002401+0800 AppLovin MAX Demo App - ObjC[1526:55660] [AppLovinSdk] ERROR [ALMediationAdapterWrapper] Failed start loading [ALMediatedAdViewAd thirdPartyAdPlacementIdentifier=IAB_BANNER_1-6722317, adUnitIdentifier=55f1fdf557bea516, format=BANNER, networkName=Vungle] : *** -[__NSDictionaryM setObject:forKeyedSubscript:]: key cannot be nil
(lldb) po error
[MAError: code=-5001, message=MAX returned eligible ads from mediated networks, but all ads failed to load. Inspect -[MAError waterfall] for more info., mediatedNetworkErrorCode=-1, mediatedNetworkErrorMessage=]
Trough debugging, found that the self.placementIdentifier is nil when self.adViewbidResponseDict[self.placementIdentifier] = bidResponse;, we need to put self.placementIdentifier = parameters.thirdPartyAdPlacementIdentifier; before self.adViewbidResponseDict[self.placementIdentifier] = bidResponse;
After put self.placementIdentifier = parameters.thirdPartyAdPlacementIdentifier; before self.adViewbidResponseDict[self.placementIdentifier] = bidResponse; We can receive Bidding Banner ads:
Thanks a lot. :)
There was a problem hiding this comment.
Good catch. i forgot to remove this. we dont need it.
* Address Banner and MREC ad display issue. This commit will update the show ad for Banner/Mrec to be called after the ad finishes downloading the assets. Also updates the finish display ad to be called on destroy. IOS-5559 IOS-5560
* Address Banner and MREC ad display issue. This commit will update the show ad for Banner/Mrec to be called after the ad finishes downloading the assets. Also updates the finish display ad to be called on destroy. IOS-5559 IOS-5560
This commit will update the show ad for Banner/Mrec to be called after the ad finishes downloading the assets.
IOS-5559
IOS-5560