[simd] Add spec tests for v128.const #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Honry
commented
Jul 5, 2019
| (assert_return (invoke "f") (v128.const f32x4 +0x1.fffffep127 +0x1.fffffep127 +0x1.fffffep127 +0x1.fffffep127)) | ||
| (module (func (export "f") (result v128) (v128.const f32x4 -0x1.fffffe8p127 -0x1.fffffe8p127 -0x1.fffffe8p127 -0x1.fffffe8p127))) | ||
| (assert_return (invoke "f") (v128.const f32x4 -0x1.fffffep127 -0x1.fffffep127 -0x1.fffffep127 -0x1.fffffep127)) | ||
| (module (func (export "f") (result v128) (v128.const f32x4 +0x1.fffffefffffffffffp127 +0x1.fffffefffffffffffp127 +0x1.fffffefffffffffffp127 +0x1.fffffefffffffffffp127))) |
There was a problem hiding this comment.
Same case for 0x1.fffffefffffffffffp127, which is treated as a too large float literal in WAVM.
|
Cc/ @AndrewScheidecker, @tlively, @arunetm, PTAL. thanks! |
tlively
approved these changes
Jul 5, 2019
| (module (func (v128.const f32x4 -340282356779733623858607532500980858880 -340282356779733623858607532500980858880 | ||
| -340282356779733623858607532500980858880 -340282356779733623858607532500980858880) drop)) | ||
| (module (func (v128.const f32x4 nan:0x1 nan:0x1 nan:0x1 nan:0x1) drop)) | ||
| (module (func (v128.const f32x4 nan:0x7f_ffff nan:0x7f_ffff nan:0x7f_ffff nan:0x7f_ffff) drop)) |
There was a problem hiding this comment.
Would it be useful to test using multiple representations in a single v128.const?
There was a problem hiding this comment.
I guess more generally, do you think it would be useful to test non-splat vectors? I suppose that might blow up the test space too much.
There was a problem hiding this comment.
Good proposal! I will add them in a follow-up.
kenohassler
pushed a commit
to fgsect/WAFL
that referenced
this pull request
Oct 18, 2021
[simd] Add spec tests for v128.const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.