Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add super linter 1264 #1600

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

DanielFLopez
Copy link
Contributor

@DanielFLopez DanielFLopez commented Aug 12, 2021

fix #1264

fix HTML errors
fix jinja warnings
remove duplicate code
fix indentation errors
reformat HTML code
reformat Python code using black

add super linter to GitHub action verifying flake8 and Black (flake8 is using Black profile for avoiding conflicts)
add jscpd check

@DanielFLopez DanielFLopez changed the title [WIP] Add super linter 1264 Add super linter 1264 Aug 13, 2021
@DanielFLopez DanielFLopez marked this pull request as ready for review August 13, 2021 15:40
@carlinmack
Copy link
Collaborator

add jscpd check

Just wondering, but do we need jscpd?

@DanielFLopez
Copy link
Contributor Author

add jscpd check

Just wondering, but do we need jscpd?

super linter runs automatically jscpd if it is not necessary I can disable it

@DanielFLopez
Copy link
Contributor Author

@egonw can you review this?

@egonw
Copy link
Collaborator

egonw commented Aug 17, 2021

@egonw can you review this?

no, I'm afraid not. This is really up to @fnielsen. this is outside my expertise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use black to standardize code formatting
3 participants