Owc fix: no need for h5 #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmruehl
requested changes
May 13, 2025
Collaborator
There was a problem hiding this comment.
@dforbush2 this case isn't running for me. Can you please review and revise?
Error using wecSim (line 43)
Solver encountered an error while simulating model 'OWC_GBM' at time 2.71373531488104e-06
and cannot continue. Please check the model for errors.
Caused by:
Error using wecSim (line 43)
Nonlinear iteration is not converging with step size reduced to hmin (9.64112E-21) at time
2.71374E-06. Try reducing the minimum step size and/or relax the relative error
tolerance.
Collaborator
Collaborator
| % simu.solver = 'ode45'; % simu.solver = 'ode4' for fixed step & simu.solver = 'ode45' for variable step | ||
| simu.solver = 'ode23t'; % simu.solver = 'ode4' for fixed step & simu.solver = 'ode45' for variable step | ||
| simu.dt = 0.005; % Simulation time-step [s] | ||
| simu.cicEndTime = 15; |
Collaborator
There was a problem hiding this comment.
I was unable to run this simulation. I attempted to run different solvers, different time-steps, but nothing worked. I got a convergence error each time.
| body(1) = bodyClass('./hydroData/test17a.h5'); | ||
| % body(1) = bodyClass('./hydroData/test17a.h5'); | ||
| body(1) = bodyClass('./hydroData/test17a_clean.h5'); | ||
| %Create the body(1) Variable, Set Location of Hydrodynamic Data File |
Collaborator
There was a problem hiding this comment.
I also tried running both the original and cleaned h5 files, and got the same convergence error.
Collaborator
|
@MShabara this is ready for your review. The OWC GBM case is still not running, so please see if you can debug it. Thanks! |
…tions into dforbush2-OWCFix
MShabara
approved these changes
May 15, 2025
Contributor
MShabara
left a comment
MShabara
left a comment
There was a problem hiding this comment.
The PR is good to be merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this places all the needed WAMIT output files into the hydroData directory with bemio.m, or, as recommended in readMe, badBemioFix_fcn.m