Skip to content

Conversation

@akeeste
Copy link
Contributor

@akeeste akeeste commented May 13, 2025

This PR restores 2 of 3 broken application library links (Controls\MPC and WECCCOMP\WECCCOMP_Nonlinear_Model_Predictive). The two models files in these cases manually broken library links to pull the excitation force on certain bodies. As of #1411, this feature is built into dev and the links can be restored, reducing our upkeep.

@akeeste akeeste requested a review from kmruehl May 13, 2025 22:00
@akeeste
Copy link
Contributor Author

akeeste commented May 14, 2025

The 3rd application that contains a broken library link is the OWC\OrificeModel. That link cannot be restored because there is a custom orifice model function with the flex body

@kmruehl
Copy link
Collaborator

kmruehl commented May 14, 2025

@akeeste the WECCCOMP\WECCCOMP_Nonlinear_Model_Predictive case is not running for me. It's not erroring, it just gets hung up in an initialization stage.

@kmruehl kmruehl requested a review from jtgrasb May 14, 2025 19:27
@kmruehl
Copy link
Collaborator

kmruehl commented May 14, 2025

Confirmed that these cases both run for @jtgrasb and @kmruehl

@kmruehl kmruehl merged commit c88dd0e into WEC-Sim:dev May 14, 2025
7 of 9 checks passed
@akeeste akeeste deleted the restore_app_links branch May 14, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants