-
Notifications
You must be signed in to change notification settings - Fork 57
QTF Example #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QTF Example #86
Conversation
|
@MShabara I tried running this case to test it out, but it looks like the QTFs aren't included in the BEM results from NEMOH. Based on our Also, since you are changing the case slightly by adding the QTFs, we expect that the results should change slightly. We will need to update the original data that the regression test compares to. |
|
@MShabara Just tested this out and it works now. Looking at the failing tests, it does look like the results are just changed slightly by the addition of QTFs. The original data that its comparing to can be updated to reflect the addition of QTFs and should pass once updated.
|
|
@jtgrasb, to avoid the influence of the QTF on both test cases, I’m limiting the tests to the Constant case only for now. I'll resume full testing once the issue is resolved. |
|
@MShabara I pushed to this PR to force the tests to rerun. A couple of notes:
|
disables the QTF calculation in the example case
|
@jtgrasb The QTFs were disabled for this PR. |
|
Looks good, merging now. |

This PR modifies the MOST example files to enable the second order forces calculation.
The PR to be reviewed after merging PR 1472