Skip to content

Conversation

@MShabara
Copy link
Contributor

No description provided.

@jtgrasb
Copy link
Contributor

jtgrasb commented May 16, 2025

@MShabara Looks like the PR only removed the test and didn't actually add it back. I added it back now. One thing I noticed is that the floating OWC BEM data is in both the common_input_files and the OWC case. Is there a reason for this or can we remove it from one of these locations?

@MShabara
Copy link
Contributor Author

@jtgrasb This PR was intended to (1) move the test to the OWC parent library and (2) update the name of the Floating OWC case to be FloatingOWC. However, those changes didn’t seem to get pushed initially. I've now added them.

The BEM data for the Floating OWC had been moved from the common_input_files directory to the FloatingOWC case directory.

The tests are passing locally but they fail on github.

@jtgrasb jtgrasb self-requested a review May 21, 2025 13:44
@jtgrasb
Copy link
Contributor

jtgrasb commented May 21, 2025

@MShabara Thanks for the updates. I tested locally as well and the tests pass.

It looks like the runner is having difficulty finding the changed folder/test because it changed names/location. Once its merged, I expect the tests will pass fine.

This PR is ready to be merged.

@MShabara MShabara merged commit 7cf01a1 into WEC-Sim:dev May 22, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants