-
Notifications
You must be signed in to change notification settings - Fork 57
Add variable mass example #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
akeeste
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jtgrasb. I pushed a few miscellaneous clean up items (removing commented lines that weren't used, minor formatting, etc) and added a README.
See my couple of outstanding comments on simplifying the BEM and geometry files included in the PR.
Now that we're demonstrating the feature, do you still feel confident in our variable mass implementation? Not doubting our previous work, I just didn't double check it here
|
@akeeste Thanks, I made the suggested changes. As for confidence in our implementation, I am feeling pretty confident. However, I would like to do a more detailed verification with comparisons to non-variable mass models. I don't think it would be too difficult and would increase confidence. I'll work on this in the next couple weeks before merging. |
|
@akeeste I made some slight changes to clean up the model and wrap up some final tasks:
This PR should be ready for final review and merge. |
akeeste
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jtgrasb, this case looks good to me. I agree that we could improve this case by more accurately simulating the water intake and the influence on cg and inertia, but for now I think we should merge this as a demonstration of how to vary the mass using variable hydro.

This PR adds an example of a variable mass WEC as enabled by WEC-Sim/WEC-Sim#1465 into WEC-Sim source. As of now, the example just runs a sphere (r = 5m) with varying mass and draft in a regular wave. The draft increases from 1 m to 9 m and can represent a WEC taking in water to increase draft. However, I assumed a constant density meaning the CG doesn't change relative to the sphere's center.
For now, this is an example of how to implement a variable mass WEC in WEC-Sim, but it is not a very practical case. Here are my ideas for details to add (open to suggestions):