-
Notifications
You must be signed in to change notification settings - Fork 57
Update MOST application to v2 #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
These tests are finally functioning correctly, but the regression aspect is failing once again even with a freshly updated "original" dataset to test against. I suggest that we temporarily deprecate the MOST regression tests until we can really figure out the cause of and isolate whatever randomness comes from the pre-processing. |
|
I've rerun this regression test locally multiple times with all pre-processing and the test passes. Unsure why it fails on the runner. Team consensus to briefly review this PR and merge without a working regression test. I commented out the regression portion of the MOST tests in the last commit |
|
I'm going to merge this PR. In discussions, we talked about how significantly the case has changed and for this PR just wanted to ensure that someone other than me (being the PR author) can run it. Since it is running on the CI, I think that meets our purposes and I will merge so that we can continue working through issues for v7 |
This PR updates the MOST application to work with MOST v2 which was recently brought into dev. It refactors the regression test with new data.
@MShabara I kept your QTF updates to the hydro data, but otherwise replaced the case with https://github.com/MOREnergylab/MOST/tree/master/Examples/VolturnUS