Skip to content

Conversation

@akeeste
Copy link
Contributor

@akeeste akeeste commented Jul 30, 2025

This PR updates the MOST application to work with MOST v2 which was recently brought into dev. It refactors the regression test with new data.

@MShabara I kept your QTF updates to the hydro data, but otherwise replaced the case with https://github.com/MOREnergylab/MOST/tree/master/Examples/VolturnUS

@akeeste
Copy link
Contributor Author

akeeste commented Aug 5, 2025

These tests are finally functioning correctly, but the regression aspect is failing once again even with a freshly updated "original" dataset to test against. I suggest that we temporarily deprecate the MOST regression tests until we can really figure out the cause of and isolate whatever randomness comes from the pre-processing.

@akeeste
Copy link
Contributor Author

akeeste commented Aug 6, 2025

I've rerun this regression test locally multiple times with all pre-processing and the test passes. Unsure why it fails on the runner. Team consensus to briefly review this PR and merge without a working regression test.

I commented out the regression portion of the MOST tests in the last commit

@akeeste
Copy link
Contributor Author

akeeste commented Aug 14, 2025

I'm going to merge this PR. In discussions, we talked about how significantly the case has changed and for this PR just wanted to ensure that someone other than me (being the PR author) can run it. Since it is running on the CI, I think that meets our purposes and I will merge so that we can continue working through issues for v7

@akeeste akeeste merged commit ae1fb77 into WEC-Sim:dev Aug 14, 2025
3 checks passed
@akeeste akeeste deleted the most_v2_apps branch August 14, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant