-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSU summarizer in item view is split into rows weirdly #162
Comments
|
Better but harder alternative: split on ( and ), but not on the commas between them |
This breaks Motherboard summaries, the only way to properly do this seems to be in returning an array of strings from |
@Learath2 Yes please, do the array thing, I've been thinking about it for ages but never found the time to implement it. The new API that returns summaries should also return an array, too |
Q: What is our API policy? Can we break stuff or should we introduce a new endpoint for the new behaviour? A string -> array change will most definitely break some API clients (if there are any that use the summary endpoint that is). |
Since all clients are under our control, we generally modify clients when we make big API changes. If that's not possible, we can make a new endpoint, but that was never necessary. I can also tell you there are no clients at the moment using the summary endpoint, so go ahead and modify it. |
Rework summarizer to output in tokens. Close #162
Update the summarizer to remove () so it doesn't look weird when split in multiple lines
The text was updated successfully, but these errors were encountered: