Vendor numba-scipy #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/numba/numba-scipy 1e2f24417df873ed4e55bb79bc6f04cad8b1ed21
it's now vendored in
valpesendorfer
approved these changes
Jan 10, 2024
| @@ -1,2 +1,2 @@ | |||
| """Version only in this file.""" | |||
| __version__ = "0.2.0" | |||
| __version__ = "0.2.1" | |||
There was a problem hiding this comment.
you consider this a patch release? We've got 0.3.0 pending with the other PR. Should we do 0.2.1 here and bump with the other one?
There was a problem hiding this comment.
anything goes before 1.0 according semantic versioning standard. I just needed a version bump to test conda install. I don't think our user-base is wide enough to think too much about these things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed before, vendoring in numba-scipy code to avoid unnecessarily old constraints on scipy and as a result old numpy.
I tried to keep edits to a minimum in the vendored code, but could not get mypy to ignore the file so had to add
type: ignorein there.