[DRAFT]: Divided AA into drought and storm layers #1370
Conversation
| return; | ||
| } | ||
|
|
||
| // Change AA layer in url |
There was a problem hiding this comment.
TODO: Changes in this file are wip.
should rework AA layers switch in url, currently not working correctly
There was a problem hiding this comment.
switch between AA in url is now working but date query no longer appear in url after switch
| @@ -3,7 +3,7 @@ import { Provider } from 'react-redux'; | |||
| import { BrowserRouter } from 'react-router-dom'; | |||
There was a problem hiding this comment.
I think the views (District, Forecast, Hometable, Timeline...) will be different for AA storm so they should probably live under AA Drought? What do you think?
There was a problem hiding this comment.
I guess we can move it later, I just want to be careful when copying components like this not to carry over extra complexity and avoidable dependence
There was a problem hiding this comment.
yes, I have not yet touched on the distinction between the view elements specific to each AA. Also i wanted to test if everything was loaded correctly when i switch AA.
I'm going to see what can be put in common for the two AA types, perhaps extracting common parts.
But I understand that the current view elements are specific to AA drought and must be separated from AA storm
There was a problem hiding this comment.
I have moved the AA drought specific components to AADroughtPanel folder
|
Build succeeded and deployed at https://prism-1370.surge.sh |
…m:WFP-VAM/prism-app into feat/handle-multiple-AA-layers-and-panels
Max-Z80
force-pushed
the
feat/handle-multiple-AA-layers-and-panels
branch
from
e3e89d9 to
26dc723
Compare
| @@ -37,7 +38,7 @@ export function keepLayer(layer: LayerType, newLayer: LayerType) { | |||
| return false; | |||
| } | |||
|
|
|||
| if (newLayer.type === layer.type && layer.type === 'anticipatory_action') { | |||
| if (newLayer.type === layer.type && isAnticipatoryActionLayer(layer.type)) { | |||
There was a problem hiding this comment.
I believe this will only be needed for aa_drought
There was a problem hiding this comment.
Yes, this is only relevant for the aa_drought because it handles the fact that aa_drought can display the layer of each 'window' simultanously on the map. There is no concept of window in the aa_storm layer, as far as I know. I will fix that.
Description
How to test the feature:
Checklist - did you ...
Test your changes with
REACT_APP_COUNTRY=rbd yarn startREACT_APP_COUNTRY=cambodia yarn startREACT_APP_COUNTRY=mozambique yarn startScreenshot/video of feature: